From affd938f7eb7cca06267e89682d42594cd7f89e5 Mon Sep 17 00:00:00 2001
From: Thomas von Deyen <thomas@vondeyen.com>
Date: Thu, 4 Apr 2024 17:21:30 +0200
Subject: [PATCH] Do not show theme selector if only one theme is configured

There is no usecase for selecting from one theme.

(cherry picked from commit d7ce8790056e2e7b0bc587cf6b19b5707a3ac4e9)
---
 .../admin/shared/_theme_selection.html.erb    | 36 ++++++++-------
 .../_theme_selection_solidus_admin.html.erb   | 46 ++++++++++---------
 2 files changed, 43 insertions(+), 39 deletions(-)

diff --git a/backend/app/views/spree/admin/shared/_theme_selection.html.erb b/backend/app/views/spree/admin/shared/_theme_selection.html.erb
index ad138748bce..a9c8aa204b9 100644
--- a/backend/app/views/spree/admin/shared/_theme_selection.html.erb
+++ b/backend/app/views/spree/admin/shared/_theme_selection.html.erb
@@ -1,21 +1,23 @@
 <% theme_options_for_select = Spree::Backend::Config.themes.keys.map { |theme| [theme.to_s.humanize, theme] }.sort %>
 
-<%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "light-only") do %>
-  <%= hidden_field_tag :system_theme, :light %>
-  <label class="admin-navbar-selection">
-    <i class="fa fa-sun-o fa-fw" title="<%= I18n.t('spree.choose_dashboard_theme') %>"></i>
-    <select name="switch_to_theme" class="custom-select fullwidth" onchange="this.form.requestSubmit()">
-      <%= options_for_select(theme_options_for_select, session[:admin_light_theme] || Spree::Backend::Config.theme) %>
-    </select>
-  </label>
-<% end %>
+<% if theme_options_for_select.length > 1 %>
+  <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "light-only") do %>
+    <%= hidden_field_tag :system_theme, :light %>
+    <label class="admin-navbar-selection">
+      <i class="fa fa-sun-o fa-fw" title="<%= I18n.t('spree.choose_dashboard_theme') %>"></i>
+      <select name="switch_to_theme" class="custom-select fullwidth" onchange="this.form.requestSubmit()">
+        <%= options_for_select(theme_options_for_select, session[:admin_light_theme] || Spree::Backend::Config.theme) %>
+      </select>
+    </label>
+  <% end %>
 
-<%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "dark-only") do %>
-  <%= hidden_field_tag :system_theme, :dark %>
-  <label class="admin-navbar-selection">
-    <i class="fa fa-moon-o fa-fw" title="<%= I18n.t('spree.choose_dashboard_theme') %>"></i>
-    <select name="switch_to_theme" class="custom-select fullwidth" onchange="this.form.requestSubmit()">
-      <%= options_for_select(theme_options_for_select, session[:admin_dark_theme] || Spree::Backend::Config.dark_theme) %>
-    </select>
-  </label>
+  <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "dark-only") do %>
+    <%= hidden_field_tag :system_theme, :dark %>
+    <label class="admin-navbar-selection">
+      <i class="fa fa-moon-o fa-fw" title="<%= I18n.t('spree.choose_dashboard_theme') %>"></i>
+      <select name="switch_to_theme" class="custom-select fullwidth" onchange="this.form.requestSubmit()">
+        <%= options_for_select(theme_options_for_select, session[:admin_dark_theme] || Spree::Backend::Config.dark_theme) %>
+      </select>
+    </label>
+  <% end %>
 <% end %>
diff --git a/backend/app/views/spree/admin/shared/_theme_selection_solidus_admin.html.erb b/backend/app/views/spree/admin/shared/_theme_selection_solidus_admin.html.erb
index de8531c9277..0b2ffeb783e 100644
--- a/backend/app/views/spree/admin/shared/_theme_selection_solidus_admin.html.erb
+++ b/backend/app/views/spree/admin/shared/_theme_selection_solidus_admin.html.erb
@@ -1,25 +1,27 @@
 <% theme_options_for_select = Spree::Backend::Config.themes.keys.map { |theme| [theme.to_s.humanize, theme] }.sort %>
 
-<li>
-  <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "light-only") do %>
-    <%= hidden_field_tag :system_theme, :light %>
-    <label>
-      <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-sun-line"></use></svg>
-      <select name="switch_to_theme" onchange="this.form.requestSubmit()">
-        <%= options_for_select(theme_options_for_select, session[:admin_light_theme] || Spree::Backend::Config.theme) %>
-      </select>
-      <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-expand-up-down-line"></use></svg>
-    </label>
-  <% end %>
+<% if theme_options_for_select.length > 1 %>
+  <li>
+    <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "light-only") do %>
+      <%= hidden_field_tag :system_theme, :light %>
+      <label>
+        <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-sun-line"></use></svg>
+        <select name="switch_to_theme" onchange="this.form.requestSubmit()">
+          <%= options_for_select(theme_options_for_select, session[:admin_light_theme] || Spree::Backend::Config.theme) %>
+        </select>
+        <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-expand-up-down-line"></use></svg>
+      </label>
+    <% end %>
 
-  <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "dark-only") do %>
-    <%= hidden_field_tag :system_theme, :dark %>
-    <label>
-      <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-moon-line"></use></svg>
-      <select name="switch_to_theme" onchange="this.form.requestSubmit()">
-        <%= options_for_select(theme_options_for_select, session[:admin_dark_theme] || Spree::Backend::Config.dark_theme) %>
-      </select>
-      <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-expand-up-down-line"></use></svg>
-    </label>
-  <% end %>
-</li>
+    <%= form_tag(spree.admin_set_theme_path(format: :html), method: :put, style: "width: 100%;", class: "dark-only") do %>
+      <%= hidden_field_tag :system_theme, :dark %>
+      <label>
+        <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-moon-line"></use></svg>
+        <select name="switch_to_theme" onchange="this.form.requestSubmit()">
+          <%= options_for_select(theme_options_for_select, session[:admin_dark_theme] || Spree::Backend::Config.dark_theme) %>
+        </select>
+        <svg aria-hidden="true"><use xlink:href="<%= image_path('spree/backend/themes/solidus_admin/remixicon.symbol.svg') %>#ri-expand-up-down-line"></use></svg>
+      </label>
+    <% end %>
+  </li>
+<% end %>