Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate version keys when label is set to alpine #537

Closed
wkrause13 opened this issue Sep 26, 2024 · 0 comments · Fixed by #536
Closed

Duplicate version keys when label is set to alpine #537

wkrause13 opened this issue Sep 26, 2024 · 0 comments · Fixed by #536

Comments

@wkrause13
Copy link
Contributor

The way this utility is generating the json for the changelog used by our documentation portal results in duplicate entries when the release label is "alpine". There is no way to distinguish between these releases. I believe versions should be unique keys or at a minimum contain enough data in the payload to distinguish between the releases.

Here is one example from gloo enterprise:

        {
          "v1.16.11": {
            "Categories": {
              "Dependency Bumps": [
                {
                  "Note": "solo-io/gloo has been upgraded to v1.16.16."
                }
              ],
              "Fixes": [
                {
                  "Note": "Fix an issue where the wrong query param was discovered for a rest resolver. (https://github.com/solo-io/solo-projects/issues/6275)"
                },
                {
                  "Note": "Fixing MaxDepth not processed and propagated to envoy. (https://github.com/solo-io/solo-projects/issues/6372)"
                }
              ]
            },
            "ExtraNotes": null,
            "HeaderSuffix": " (Uses OSS [v1.16.16](https://github.com/solo-io/gloo/releases/tag/v1.16.16))",
            "CreatedAt": 1718805188
          }
        },
        {
          "v1.16.11": {
            "Categories": {
              "Fixes": [
                {
                  "Note": "Keep Alpine branch alive for some 1.16 branches (https://github.com/solo-io/gloo/issues/8849)"
                },
                {
                  "Note": "Adds the `host_rewrite_header` to the route options to allow envoy to swapped the host header with the content of given downstream or custom header. Pay attention to the potential security implications of using this option. Provided header must come from trusted source. (https://github.com/solo-io/gloo/issues/9579)",
                  "FromDependentVersion": "v1.16.16"
                },
                {
                  "Note": "Previously, header names consisting of invalid characters such as '()[]:;,\u003c=\u003e' were accepted when passed via the healthCheck or headerManipulation `requestHeadersToAdd` parameter. This resulted in envoy throwing an `invalid header name` error. Now, header names are validated according to RFC 9110, which is the same validation used by envoy. If a header name consisting of invalid characters is passed via the aforementioned parameters, it is caught and rejected in edge and does not propagate to envoy. (https://github.com/solo-io/gloo/issues/9622)",
                  "FromDependentVersion": "v1.16.16"
                }
              ]
            },
            "ExtraNotes": null,
            "HeaderSuffix": " (Uses OSS [v1.16.16](https://github.com/solo-io/gloo/releases/tag/v1.16.16))",
            "CreatedAt": 1718890534
          }
        },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant