Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONIC OpenSSL FIPS 140-3 HLD #955

Merged
merged 5 commits into from
Apr 12, 2022
Merged

SONIC OpenSSL FIPS 140-3 HLD #955

merged 5 commits into from
Apr 12, 2022

Conversation

xumia
Copy link
Contributor

@xumia xumia commented Mar 2, 2022 •
edited
Loading

@xumia xumia force-pushed the openssl-fips-140 branch from 3d4f19c to 54a5443 Compare March 9, 2022 23:15
@xumia
Copy link
Contributor Author

xumia commented Apr 1, 2022 •
edited
Loading

@eddyk-nvidia, @eddyk-smart, @Yarden-Z, @qiluo-msft , do you have more comments? Could you please help approve it if no more comments? Thanks so much.

qiluo-msft
qiluo-msft approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check with other reviewers.

@xumia
Copy link
Contributor Author

xumia commented Apr 8, 2022

@eddyk-nvidia, @eddyk-smart, @Yarden-Z, do you have more comments? Could you please help approve it if no more comments? Thanks so much.

1 similar comment
@xumia
Copy link
Contributor Author

xumia commented Apr 11, 2022

@eddyk-nvidia, @eddyk-smart, @Yarden-Z, do you have more comments? Could you please help approve it if no more comments? Thanks so much.

@eddyk-nvidia
Copy link

no more comments from my side (@eddyk-smart is also me, my old account :-))

@xumia
Copy link
Contributor Author

xumia commented Apr 11, 2022

no more comments from my side (@eddyk-smart is also me, my old account :-))

@eddyk-nvidia, thanks for your reply.

@xumia
Copy link
Contributor Author

xumia commented Apr 11, 2022

@Yarden-Z, do you have more comments?

@xumia xumia merged commit 070758e into sonic-net:master Apr 12, 2022
@zhangyanzhao
Copy link
Collaborator

@xumia please add the code PR for tracking.

@xumia
Copy link
Contributor Author

xumia commented May 7, 2022

@xumia please add the code PR for tracking.
Support SONiC OpenSSL FIPS 140-3 based on SymCrypt engine
sonic-net/sonic-buildimage#9573

@zhangyanzhao
Copy link
Collaborator

@xumia would you please add all the code PRs by referring to EVPN VxLAN update for platforms using P2MP tunnel based L2 forwarding by dgsudharsan · Pull Request #806 · Azure/SONiC (github.com) as an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyk-nvidia eddyk-nvidia eddyk-nvidia left review comments

@eddyk-smart eddyk-smart eddyk-smart left review comments

@Yarden-Z Yarden-Z Yarden-Z approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xumia @eddyk-nvidia @zhangyanzhao @qiluo-msft @eddyk-smart @Yarden-Z