Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYSTEM READY #977

Merged
merged 1 commit into from
May 17, 2022
Merged

SYSTEM READY #977

merged 1 commit into from
May 17, 2022

Conversation

sg893052
Copy link
Contributor

@sg893052 sg893052 commented Apr 6, 2022

Support for System Ready ( Followup to #875)

Repo PR title State
sonic-buildimage System Ready
sonic-utilities Show commands for System Ready

@sg893052
Copy link
Contributor Author

sg893052 commented Apr 6, 2022

Followup to #875

@yxieca yxieca force-pushed the master branch 2 times, most recently from 8498931 to 8837dc2 Compare April 15, 2022 16:51
@adyeung
Copy link
Collaborator

adyeung commented May 9, 2022

@Junchao-Mellanox pls help review and signoff

@sujinmkang sujinmkang merged commit f7c78fd into sonic-net:master May 17, 2022
@liat-grozovik
Copy link
Collaborator

@sg893052 will you consider having a sonic-mgmt test for it? if not, can you please clarfiy how we can ensure this feature is fully working on every release? do we have any functional test running on vsimage?

@liat-grozovik
Copy link
Collaborator

@sg893052 i am missing the command reference update with the new CLIs. it is not part of the PR listed in this description. Do you have another PR which you can add to the list? if not, can you please have a dedicated one and add it to the list of PRs to be tracked?
BTW the provided the tests in the utilities are very minimal and i am not sure they are covering all the flows. Could you please consider enhancing it?

@sujinmkang FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants