-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LAG] Inconsistency in LAG members configuration in config DB #11873
Closed
Labels
Comments
legacy issue, minigraph LAG member ("members@") should be deprecated if no component uses it. |
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this issue
Feb 3, 2023
… minigraph When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency. Fixes sonic-net#11873. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
8 tasks
6 tasks
yejianquan
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this issue
Feb 27, 2023
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Description of PR Summary: Fixes sonic-net/sonic-buildimage#11873 sonic-net/sonic-buildimage#11873 Approach What is the motivation for this PR? The members entry in the PORTCHANNEL table has been removed. Switch to using PORTCHANNEL_MEMBERS instead. Related to sonic-net/sonic-buildimage#13660 sonic-net/sonic-buildimage#13660
yejianquan
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this issue
Feb 27, 2023
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> Description of PR Summary: Fixes sonic-net/sonic-buildimage#11873 sonic-net/sonic-buildimage#11873 Approach What is the motivation for this PR? The members entry in the PORTCHANNEL table has been removed. Switch to using PORTCHANNEL_MEMBERS instead. Related to sonic-net/sonic-buildimage#13660 sonic-net/sonic-buildimage#13660
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this issue
Mar 1, 2023
… minigraph (sonic-net#13660) Fixes sonic-net#11873. When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
8 tasks
yxieca
pushed a commit
that referenced
this issue
Mar 1, 2023
… minigraph (#13660) (#14028) Fixes #11873. When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this issue
Mar 19, 2023
… minigraph (sonic-net#13660) Fixes sonic-net#11873. #### Why I did it When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
mssonicbld
pushed a commit
that referenced
this issue
Mar 20, 2023
… minigraph (#13660) Fixes #11873. #### Why I did it When loading from minigraph, for port channels, don't create the members@ array in config_db in the PORTCHANNEL table. This is no longer needed or used. In addition, when adding a port channel member from the CLI, that member doesn't get added into the members@ array, resulting in a bit of inconsistency. This gets rid of that inconsistency.
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this issue
Mar 28, 2023
Related work items: sonic-net#276, sonic-net#305, sonic-net#332, sonic-net#338, sonic-net#339, sonic-net#1188, sonic-net#1192, sonic-net#1197, sonic-net#1206, sonic-net#1685, sonic-net#1690, sonic-net#1696, sonic-net#1699, sonic-net#1709, sonic-net#1727, sonic-net#1737, sonic-net#1741, sonic-net#1742, sonic-net#2511, sonic-net#2512, sonic-net#2532, sonic-net#2559, sonic-net#2626, sonic-net#2638, sonic-net#2645, sonic-net#2649, sonic-net#2660, sonic-net#2669, sonic-net#2670, sonic-net#2678, sonic-net#10084, sonic-net#11442, sonic-net#11873, sonic-net#12047, sonic-net#12110, sonic-net#12207, sonic-net#12529, sonic-net#12678, sonic-net#13235, sonic-net#13287, sonic-net#13372, sonic-net#13395, sonic-net#13456, sonic-net#13497, sonic-net#13522, sonic-net#13545, sonic-net#13547, sonic-net#13552, sonic-net#13569, sonic-net#13572, sonic-net#13578, sonic-net#13591, sonic-net#13611, sonic-net#13647, sonic-net#13649, sonic-net#13660, sonic-net#13710, sonic-net#13716, sonic-net#13724, sonic-net#13726, sonic-net#13732, sonic-net#13735, sonic-net#13739, sonic-net#13757, sonic-net#13786, sonic-net#13792, sonic-net#13800, sonic-net#13801, sonic-net#13802, sonic-net#13805, sonic-net#13806, sonic-net#13812, sonic-net#13814, sonic-net#13822, sonic-net#13831, sonic-net#13834, sonic-net#13847, sonic-net#13870, sonic-net#13882, sonic-net#13884, sonic-net#13885, sonic-net#13894, sonic-net#13895, sonic-net#13926, sonic-net#13932, sonic-net#13935, sonic-net#13942, sonic-net#13951, sonic-net#13953, sonic-net#13964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When adding ports to lag using minigraph, 2 tables contain the lag membership information, PORTCHANNEL and PORTCHANNEL_MEMBER.
But when we adding ports to LAG using CLI, only 1 table contains the lag membership information, PORTCHANNEL_MEMBER.
When I deployed t0 topology (that contains lag) using minigraph, "members@" field is being created in PORTCHANNEL table.
Link to code snippet that adds the “members@” field to PORTCHANNEL table.
When I created lag using the following CLI commands:
#config portchannel add PortChannel200
#config portchannel member add PortChannel200 Ethernet0
Field "members@" field is not created in PORTCHANNEL table.
Steps to reproduce the issue:
Install to topology using minigraph:
Configure LAG using CLI:
Describe the results you received:
The expectation is to have LAG members configuration saved in a single table.
Describe the results you expected:
Output of
show version
:root@sonic:/home/admin# show version
SONiC Software Version: SONiC.202205.139499-a5171349a
Distribution: Debian 11.4
Kernel: 5.10.0-12-2-amd64
Build commit: a517134
Build date: Thu Aug 25 15:52:49 UTC 2022
Built by: AzDevOps@sonic-build-workers-001ZUF
Platform: x86_64-mlnx_msn3800-r0
HwSKU: Mellanox-SN3800-D112C8
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1937X00527
Model Number: MSN3800-CS2FO
Hardware Revision: A2
Uptime: 11:26:29 up 15 min, 1 user, load average: 1.97, 1.90, 1.26
Date: Mon 29 Aug 2022 11:26:29
Docker images:
REPOSITORY TAG IMAGE ID SIZE
docker-syncd-mlnx 202205.139499-a5171349a 1e2f53986bf4 844MB
docker-syncd-mlnx latest 1e2f53986bf4 844MB
docker-platform-monitor 202205.139499-a5171349a 75c1a9b5c131 847MB
docker-platform-monitor latest 75c1a9b5c131 847MB
docker-orchagent 202205.139499-a5171349a 0ecb28e57007 473MB
docker-orchagent latest 0ecb28e57007 473MB
docker-teamd 202205.139499-a5171349a 5037c24fdbdb 454MB
docker-teamd latest 5037c24fdbdb 454MB
docker-macsec latest 42a2666268e9 456MB
docker-dhcp-relay latest aec46c245364 448MB
docker-sonic-telemetry 202205.139499-a5171349a 070635cc1b7c 519MB
docker-sonic-telemetry latest 070635cc1b7c 519MB
docker-router-advertiser 202205.139499-a5171349a c27126ea47e9 438MB
docker-router-advertiser latest c27126ea47e9 438MB
docker-mux 202205.139499-a5171349a 0c055af258f9 487MB
docker-mux latest 0c055af258f9 487MB
docker-lldp 202205.139499-a5171349a 9056fe6e98da 481MB
docker-lldp latest 9056fe6e98da 481MB
docker-database 202205.139499-a5171349a 97070b04accb 438MB
docker-database latest 97070b04accb 438MB
docker-sflow 202205.139499-a5171349a b4ed262d4259 428MB
docker-sflow latest b4ed262d4259 428MB
docker-fpm-frr 202205.139499-a5171349a ba3d0ca10044 456MB
docker-fpm-frr latest ba3d0ca10044 456MB
docker-nat 202205.139499-a5171349a fad671ccf959 429MB
docker-nat latest fad671ccf959 429MB
docker-snmp 202205.139499-a5171349a f5935674501f 455MB
docker-snmp latest f5935674501f 455MB
docker-sonic-mgmt-framework 202205.139499-a5171349a 7a28e06406c4 556MB
docker-sonic-mgmt-framework latest 7a28e06406c4 556MB
root@sonic:/home/admin#
Output of
show techsupport
:Additional information you deem important (e.g. issue happens only occasionally):
The text was updated successfully, but these errors were encountered: