Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libwrap][ssh and snmp allow list] it's a bad way to copy binary directly from src directory into debian host OS #1574

Closed
jeromesun14 opened this issue Apr 9, 2018 · 1 comment · Fixed by #1594
Closed

[libwrap][ssh and snmp allow list] it's a bad way to copy binary directly from src directory into debian host OS #1574

jeromesun14 opened this issue Apr 9, 2018 · 1 comment · Fixed by #1594

Comments

@jeromesun14
Copy link
Contributor

Description

Feature ssh and snmp allow list copy tcpdmatch from libwrap source code directory.
We cannot cache the building result and have to compile libwarp every time. docker-base depend on libwrap, so I have to build all the dockers every time.

It's a bad smell here. sonic_debian_extention.j2:

sudo cp src/libwrap/tcp-wrappers-7.6.q/tcpdmatch $FILESYSTEM_ROOT/usr/bin

Why not using tcpd_7.6.q-25_amd64.deb as a derive package from libwrap0-dev_7.6.q-25_amd64.deb, and install it like libwrap0 in build_debian.sh?

sudo dpkg --root=$FILESYSTEM_ROOT -i target/debs/libwrap0_*.deb || \
    sudo LANG=C DEBIAN_FRONTEND=noninteractive chroot $FILESYSTEM_ROOT apt-get -y install -f
@jeromesun14 jeromesun14 changed the title [libwrap][ssh and snmp allow list] it's a bad way to copy binary directory from src directory into debian host OS [libwrap][ssh and snmp allow list] it's a bad way to copy binary directly from src directory into debian host OS Apr 10, 2018
@lguohan
Copy link
Collaborator

lguohan commented Apr 12, 2018

good suggestion, will triage.

@yurypm yurypm mentioned this issue Apr 12, 2018
Merged
lguohan pushed a commit that referenced this issue Apr 30, 2021
@stepanblyschak
[sonic-utilities] update sonic-utilities submodule (#7481)
668a678 
08337aa [sonic-package-manager] first phase implementation of sonic-package-manager (#1527)
c166f66 [multi-asic] support show ip bgp neigh/network for multi asic (#1574)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this issue May 10, 2021
@arlakshm
[multi-asic] support show ip bgp neigh/network for multi asic (sonic-…
c166f66 
…net#1574)

This change is to add support for the commands "show ip bgp neighbor "and "show ip bgp network" for multi asic platforms
Add unit tests for these commands

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this issue May 23, 2021
@stepanblyschak @raphaelt-nvidia
[sonic-utilities] update sonic-utilities submodule (sonic-net#7481)
1075833 
08337aa [sonic-package-manager] first phase implementation of sonic-package-manager (sonic-net#1527)
c166f66 [multi-asic] support show ip bgp neigh/network for multi asic (sonic-net#1574)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
@stepanblyschak
[sonic-utilities] update sonic-utilities submodule (sonic-net#7481)
1384f0e 
08337aa [sonic-package-manager] first phase implementation of sonic-package-manager (sonic-net#1527)
c166f66 [multi-asic] support show ip bgp neigh/network for multi asic (sonic-net#1574)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tcpdmatch dependency yurypm/sonic-buildimage
2 participants
@lguohan @jeromesun14