Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensord not able to start up on both master and 201911 branches #4021

Closed
keboliu opened this issue Jan 14, 2020 · 2 comments · Fixed by #4354
Closed

Sensord not able to start up on both master and 201911 branches #4021

keboliu opened this issue Jan 14, 2020 · 2 comments · Fixed by #4354
Assignees
@jleveque

Comments

@keboliu
Copy link
Collaborator

keboliu commented Jan 14, 2020

Description

Sensord inside PMON container failed to boot up in current master and 201911 branches, the error log as below:

Jan 14 07:45:39.303910 mtbc-sonic-03-2700 INFO pmon#supervisord: start.sh lm-sensors: started
Jan 14 07:45:40.165692 mtbc-sonic-03-2700 INFO pmon#supervisord: lm-sensors sensord: unrecognized service
Jan 14 07:45:45.406433 mtbc-sonic-03-2700 INFO pmon#supervisord 2020-01-14 07:45:39,262 INFO spawned: 'lm-sensors' with pid 38
Jan 14 07:45:45.406522 mtbc-sonic-03-2700 INFO pmon#supervisord 2020-01-14 07:45:39,264 INFO success: lm-sensors entered RUNNING state, process has stayed up for > than 0 seconds (startsecs)
Jan 14 07:45:45.406603 mtbc-sonic-03-2700 INFO pmon#supervisord 2020-01-14 07:45:40,166 INFO exited: lm-sensors (exit status 1; not expected)

Steps to reproduce the issue:

  1. Install an image build from master or 201911 and that can observe this issue every time after boot up.

Describe the results you received:
Sensord failed to start up

Describe the results you expected:
Sensord should work properly

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```
admin@mtbc-sonic-03-2700:~$ show version

SONiC Software Version: SONiC.HEAD.11-7ec27323
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 7ec27323
Build date: Sat Jan 11 05:50:16 UTC 2020
Built by: johnar@jenkins-worker-11

Platform: x86_64-mlnx_msn2700-r0
HwSKU: ACS-MSN2700
ASIC: mellanox
Serial Number: MT1844K07863
Uptime: 10:19:58 up  1:28,  1 user,  load average: 5.14, 5.01, 5.15

Docker images:
REPOSITORY                    TAG                 IMAGE ID            SIZE
docker-syncd-mlnx             HEAD.11-7ec27323    cd8dabb08c44        377MB
docker-syncd-mlnx             latest              cd8dabb08c44        377MB
docker-platform-monitor       HEAD.11-7ec27323    8c0064e9b6fa        569MB
docker-platform-monitor       latest              8c0064e9b6fa        569MB
docker-fpm-frr                HEAD.11-7ec27323    ad37d5eb9801        325MB
docker-fpm-frr                latest              ad37d5eb9801        325MB
docker-lldp-sv2               HEAD.11-7ec27323    557666104195        303MB
docker-lldp-sv2               latest              557666104195        303MB
docker-dhcp-relay             HEAD.11-7ec27323    ddbfd2f9df36        290MB
docker-dhcp-relay             latest              ddbfd2f9df36        290MB
docker-database               HEAD.11-7ec27323    1347dfbc1adc        282MB
docker-database               latest              1347dfbc1adc        282MB
docker-sflow                  HEAD.11-7ec27323    485e6effe8f9        305MB
docker-sflow                  latest              485e6effe8f9        305MB
docker-teamd                  HEAD.11-7ec27323    1614dde03538        305MB
docker-teamd                  latest              1614dde03538        305MB
docker-snmp-sv2               HEAD.11-7ec27323    6d1e0ca2b866        339MB
docker-snmp-sv2               latest              6d1e0ca2b866        339MB
docker-orchagent              HEAD.11-7ec27323    2b965764c0bd        323MB
docker-orchagent              latest              2b965764c0bd        323MB
docker-sonic-mgmt-framework   HEAD.11-7ec27323    16b3bbd3cbea        330MB
docker-sonic-mgmt-framework   latest              16b3bbd3cbea        330MB
docker-sonic-telemetry        HEAD.11-7ec27323    850f7d84fa44        343MB
docker-sonic-telemetry        latest              850f7d84fa44        343MB
docker-router-advertiser      HEAD.11-7ec27323    da5f613655d4        282MB
docker-router-advertiser      latest              da5f613655d4        282MB
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
@keboliu keboliu changed the title Sensord not able to start up on both master and 201911 brach Sensord not able to start up on both master and 201911 branches Jan 14, 2020
@keboliu
Copy link
Collaborator Author

keboliu commented Feb 12, 2020

@jleveque, would you please help to confirm is this only happened on the Mellanox platform or you also observed on other vendors' platforms?

@fillmorechen0928
Copy link

This issue is the same on Broadcom platform.

The pmon docker can't run "service sensord start" in script lm-sensors.sh.

Reference:
https://github.com/Azure/sonic-buildimage/blob/f49cac086f8421bf5d76a4798c4906700a322a50/dockers/docker-platform-monitor/lm-sensors.sh

CharlieChenEC added a commit to CharlieChenEC/sonic-buildimage that referenced this issue Apr 1, 2020
@CharlieChenEC
Fix the error that 'sensord' daemon cannot be spawn correctly in pmon…
fe9c3f4 
… container

- This commit fixes the issue sonic-net#4021 (Sensord not able to start up on
  both master and 201911 branches)
- Add the new patch file for "lm-sensors" to perform dh_installinit to
  include sensord.init in the packed deb. So that the missing init
  script file for 'sensord' will be included in the created 'sensord'
  deb.

Signed-off-by: Charlie Chen <charlie_chen@edge-core.com>
@CharlieChenEC CharlieChenEC mentioned this issue Apr 1, 2020
Merged
jleveque pushed a commit that referenced this issue Apr 3, 2020
@CharlieChenEC
Fix the error that 'sensord' daemon cannot be spawn correctly in pmon…
abbd871 
… container (#4354)

- This commit fixes the issue #4021 (Sensord not able to start up on
  both master and 201911 branches)
- Add the new patch file for "lm-sensors" to perform dh_installinit to
  include sensord.init in the packed deb. So that the missing init
  script file for 'sensord' will be included in the created 'sensord'
  deb.

Signed-off-by: Charlie Chen <charlie_chen@edge-core.com>
abdosi pushed a commit that referenced this issue Apr 7, 2020
@CharlieChenEC @abdosi
Fix the error that 'sensord' daemon cannot be spawn correctly in pmon…
63450d7 
… container (#4354)

- This commit fixes the issue #4021 (Sensord not able to start up on
  both master and 201911 branches)
- Add the new patch file for "lm-sensors" to perform dh_installinit to
  include sensord.init in the packed deb. So that the missing init
  script file for 'sensord' will be included in the created 'sensord'
  deb.

Signed-off-by: Charlie Chen <charlie_chen@edge-core.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this issue Apr 24, 2020
@CharlieChenEC @tiantianlv
Fix the error that 'sensord' daemon cannot be spawn correctly in pmon…
48bfef2 
… container (sonic-net#4354)

- This commit fixes the issue sonic-net#4021 (Sensord not able to start up on
  both master and 201911 branches)
- Add the new patch file for "lm-sensors" to perform dh_installinit to
  include sensord.init in the packed deb. So that the missing init
  script file for 'sensord' will be included in the created 'sensord'
  deb.

Signed-off-by: Charlie Chen <charlie_chen@edge-core.com>
@andywongarista andywongarista mentioned this issue Oct 12, 2022
Merged
7 tasks
Blueve pushed a commit that referenced this issue Oct 21, 2022
@andywongarista @byu343
Fix sensord service install (#12376)
3587489 
Why I did it
#4021 describes an issue that is still being observed on master image whereby sensord does not start in pmon due to missing service.

How I did it
Updated the lm-sensors install patch with a case for systemd

How to verify it
Verified that sensord is up in pmon after boot

Co-authored-by: Boyang Yu <byu@arista.com>
yxieca pushed a commit that referenced this issue Oct 25, 2022
@andywongarista @byu343 @yxieca
Fix sensord service install (#12376)
44d90f9 
Why I did it
#4021 describes an issue that is still being observed on master image whereby sensord does not start in pmon due to missing service.

How I did it
Updated the lm-sensors install patch with a case for systemd

How to verify it
Verified that sensord is up in pmon after boot

Co-authored-by: Boyang Yu <byu@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleveque jleveque

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jleveque @keboliu @fillmorechen0928