-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sonic-slave-stretch build failed #4315
Comments
I think related to this bug https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954852 |
I suspect not. it seems to be cause by debhelper
|
this is a tricky one. here is my analysis:
Now, we cannot go back to cmake v13.3.2 since it is no longer available. it looks like libarchive13 (3.4.0-2~bpo9+1) is in stretch-backports-sloppy |
With this change, please keep a close watch on building src/libyang. When I tried this, the newer version of cmake seems to behave differently regarding SWIG, causing the following error:
Not sure if there are any other build errors in SONiC, but this is the first one I encountered. For reference, here are the versions installed in my sonic-slave-stretch build container after making the Dockerfile.j2 changes:
-Greg |
ack. two solutions in my mind
|
Consider the following change as an additional patch in the src/libyang/patch series:
The VERSION_LESS check most likely isn't exactly right, but this is meant as an alternative to upgrading the libyang version, and is in addition to the sonic-slave-stretch/Dockerfile.j2 changes already proposed as a fix. I've not tried this with anything other than my one build that was previously unable to create the stretch base image, so it'll need some vetting. |
@gpaussabrcm, thanks for the investigation. @qiluo-msft has found the pre-built binary for 3.13.2. we are fixing using this approach. It is probably better to keep cmake the same version. i think this time lesson learned. I did not realized so many project relies on the cmake. Did not realize cmake is such a basic tool. it is probably not a good idea to cmake from stretch-backports in the first place. We should probably be more careful on accepting the pr that upgrades debhelper in the first place. after all, only one project requires debhelper >= 11. |
fix #4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix #4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix sonic-net#4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix sonic-net#4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix sonic-net#4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix sonic-net#4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
fix sonic-net#4315 download and install cmake 3.13.2 from azure storage latest cmake 3.16.3 from stretch-backports breaks the libyang 1.0.73 build Signed-off-by: Guohan Lu <lguohan@gmail.com>
Why I did it The libyang cannot be built with the latest version of cmake. Example: https://dev.azure.com/mssonic/build/_build/results?buildId=181862&view=logs&j=993d6e22-aeec-5c03-fa19-35ecba587dd9&t=d0538dec-1681-5ff8-bd45-c0de13be9706 [ 96%] Building CXX object swig/python2/CMakeFiles/_yang2.dir/yangPYTHON_wrap.cxx.o /sonic/src/libyang/libyang-1.0.73/build/swig/python2/yangPYTHON_wrap.cxx:3292:33: error: expected initializer before '.' token # define SWIG_init init_yang.so ^ /sonic/src/libyang/libyang-1.0.73/build/swig/python2/yangPYTHON_wrap.cxx:102537:1: note: in expansion of macro 'SWIG_init' SWIG_init(void) { ^~~~~~~~~ /sonic/src/libyang/libyang-1.0.73/build/swig/python2/yangPYTHON_wrap.cxx:101971:24: warning: 'swig_const_table' defined but not used [-Wunused-variable] static swig_const_info swig_const_table[] = { See relative issue: #4315 How I did it Not upgrade the cmake, change to use the dbus-python 1.2.18 which is compatible with cmake 3.13.4 How to verify it See https://dev.azure.com/mssonic/build/_build/results?buildId=194756&view=results
Description
sonic-slave-stretch cannot be built because debhelper from stretch-backports is conflicted with cmake from stretch
Without cmake, subsequent compilation will fail
sonic-jenkins can also see related logs
https://sonic-jenkins.westus2.cloudapp.azure.com/job/bldenv/job/sonic-slave-stretch/110/consoleFull
Steps to reproduce the issue:
The text was updated successfully, but these errors were encountered: