Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCIed try to get the PCIed config files from {platform}/plugin/ folder instead of {platform}/ folder #6437

Closed
keboliu opened this issue Jan 13, 2021 · 0 comments · Fixed by sonic-net/sonic-utilities#1362 or sonic-net/sonic-platform-daemons#144
Assignees

Comments

@keboliu
Copy link
Collaborator

keboliu commented Jan 13, 2021

Description

PCIed is trying to read the pcie.yml file from {platform}/plugin/ folder instead of {platform}/ folder. the plugin folder should be only for the plugins, all the platform related configuration files including pcie.yml should go to {platform}/ folder.

Steps to reproduce the issue:
run the current master image and read the PCIed code will understand that PCIed is expecting the file be placed under plugin folder.

Describe the results you received:

if you put the file under {platform}/ folder which will result in PCIed failed to start.

Jan 11 21:34:03.664365 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:03,663 INFO spawned: 'pcied' with pid 41
Jan 11 21:34:03.880880 r-anaconda-51 ERR pmon#pcied[41]: Platform pcie configuration file doesn't exist! Exiting ...
Jan 11 21:34:03.881122 r-anaconda-51 INFO pmon#/supervisord: pcied Platform PCIe Configuration file doesn't exist!
Jan 11 21:34:03.896688 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:03,896 INFO exited: pcied (exit status 1; not expected)
Jan 11 21:34:04.901144 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:04,900 INFO spawned: 'pcied' with pid 46
Jan 11 21:34:05.048296 r-anaconda-51 ERR pmon#pcied[46]: Platform pcie configuration file doesn't exist! Exiting ...
Jan 11 21:34:05.063223 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:05,062 INFO exited: pcied (exit status 1; not expected)
Jan 11 21:34:07.093888 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:07,093 INFO spawned: 'pcied' with pid 49
Jan 11 21:34:07.249277 r-anaconda-51 ERR pmon#pcied[49]: Platform pcie configuration file doesn't exist! Exiting ...
Jan 11 21:34:07.267095 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:07,266 INFO exited: pcied (exit status 1; not expected)
Jan 11 21:34:09.087807 r-anaconda-51 INFO pmon#/supervisord: message repeated 2 times: [ pcied Platform PCIe Configuration file doesn't exist!]
Jan 11 21:34:11.134432 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:11,133 INFO spawned: 'pcied' with pid 67
Jan 11 21:34:11.286396 r-anaconda-51 ERR pmon#pcied[67]: Platform pcie configuration file doesn't exist! Exiting ...
Jan 11 21:34:11.286640 r-anaconda-51 INFO pmon#/supervisord: pcied Platform PCIe Configuration file doesn't exist!
Jan 11 21:34:11.301085 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:11,300 INFO exited: pcied (exit status 1; not expected)
Jan 11 21:34:11.301299 r-anaconda-51 INFO pmon#supervisord 2021-01-11 21:34:11,301 INFO gave up: pcied entered FATAL state, too many start retries too quickly

Describe the results you expected:

PCIed should change the expecting folder and it should be started successfully with pcie.yml under {platform}/ folder.

Additional information you deem important (e.g. issue happens only occasionally):

**Output of `show version`:**

```
(paste your output here)
```

**Attach debug file `sudo generate_dump`:**

```
(paste your output here)
```
sujinmkang added a commit to sonic-net/sonic-platform-daemons that referenced this issue Feb 9, 2021
)

[pcied] Remove unnecessary message and move the configuration path from plugin directory to platform directory

This PR fixes sonic-net/sonic-buildimage#5819 and fixes sonic-net/sonic-buildimage#6437.

Remove unnecessary repeated message
Move the configuration path from plugin directory to platform directory
sujinmkang added a commit to sonic-net/sonic-utilities that referenced this issue Feb 9, 2021
…tion (#1362)

- What I did
Fixes sonic-net/sonic-buildimage#6437

- How I did it
Changed the configuration file path from plugin to platform directory

- How to verify it
Verify on the device
daall pushed a commit to sonic-net/sonic-utilities that referenced this issue Feb 16, 2021
…tion (#1362)

- What I did
Fixes sonic-net/sonic-buildimage#6437

- How I did it
Changed the configuration file path from plugin to platform directory

- How to verify it
Verify on the device
sujinmkang added a commit that referenced this issue Feb 21, 2021
…6475)

- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
#6437

- How I did it

Move all pcie.yaml configuration file from plugin to platform directory.
Remove unnecessary timer to start pcie-check.service
Move pcie-check.service to sonic-host-services
- How to verify it
Verify on the device
anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this issue Mar 2, 2021
…tion (sonic-net#1362)

- What I did
Fixes sonic-net/sonic-buildimage#6437

- How I did it
Changed the configuration file path from plugin to platform directory

- How to verify it
Verify on the device
yxieca pushed a commit that referenced this issue Mar 4, 2021
…6475)

- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
#6437

- How I did it

Move all pcie.yaml configuration file from plugin to platform directory.
Remove unnecessary timer to start pcie-check.service
Move pcie-check.service to sonic-host-services
- How to verify it
Verify on the device
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this issue Aug 7, 2021
…onic-net#6475)

- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
sonic-net#6437

- How I did it

Move all pcie.yaml configuration file from plugin to platform directory.
Remove unnecessary timer to start pcie-check.service
Move pcie-check.service to sonic-host-services
- How to verify it
Verify on the device
lolyu pushed a commit to lolyu/sonic-buildimage that referenced this issue Sep 13, 2021
…onic-net#6475)

- Why I did it
The pcie configuration file location is under plugin directory not under platform directory.
sonic-net#6437

- How I did it

Move all pcie.yaml configuration file from plugin to platform directory.
Remove unnecessary timer to start pcie-check.service
Move pcie-check.service to sonic-host-services
- How to verify it
Verify on the device
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
…tion (#1362)

- What I did
Fixes sonic-net/sonic-buildimage#6437

- How I did it
Changed the configuration file path from plugin to platform directory

- How to verify it
Verify on the device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment