Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GMock to Debian releases #12476

Closed
wants to merge 5 commits into from

Conversation

bacrossland
Copy link

Signed-off-by: bacrossland bryan.crossland@target.com

Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

08711a8 [orchdaemon]: Fixed sairedis record file rotation (#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.

How to verify it

Build compiles and passes tests

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Add GMock for testing

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

    08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.
Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

    08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.
Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

    08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.
Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

    08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.
Why I did it

Fix updated sonic-swss submodule which uses GMock for testing:

    08711a8 [orchdaemon]: Fixed sairedis record file rotation (sonic-net#2481)

How I did it

Add install of GMock to Dockerfile.j2 in all Debian releases.
@bacrossland
Copy link
Author

@liat-grozovik @dprital the pipeline is caching and breaking the proper install of libgtest.

Broken in the pipeline:

Step 42/63 : RUN apt-get install -y libgtest-dev libgmock-dev -t stretch-backports
 ---> Running in 12edc9453be8
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 libgmock-dev : Depends: libgtest-dev (= 1.8.0-10~bpo9+1) but 1.8.0-6 is to be installed
 libgtest-dev : Depends: googletest (= 1.8.0-6) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c apt-get install -y libgtest-dev libgmock-dev -t stretch-backports' returned a non-zero code: 100

Working from outside the pipeline:

root@497171c44165:/# apt-get install -y libgtest-dev libgmock-dev -t stretch-backports
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages were automatically installed and are no longer required:
  gir1.2-glib-2.0 libdbus-glib-1-2 libgirepository-1.0-1 python-crypto python-dbus python-gi python-keyring python-keyrings.alt python-pip-whl python-secretstorage
  python-wheel python-xdg python3-cffi-backend python3-crypto python3-cryptography python3-dbus python3-gi python3-idna python3-keyring python3-keyrings.alt
  python3-pyasn1 python3-secretstorage python3-setuptools python3-wheel python3-xdg
Use 'apt autoremove' to remove them.
The following additional packages will be installed:
  googletest
The following NEW packages will be installed:
  googletest libgmock-dev libgtest-dev
0 upgraded, 3 newly installed, 0 to remove and 140 not upgraded.
Need to get 1071 kB of archives.
After this operation, 9985 kB of additional disk space will be used.
Get:1 http://ftp.debian.org/debian stretch-backports/main arm64 googletest arm64 1.8.0-10~bpo9+1 [649 kB]
Get:2 http://ftp.debian.org/debian stretch-backports/main arm64 libgtest-dev arm64 1.8.0-10~bpo9+1 [205 kB]
Get:3 http://ftp.debian.org/debian stretch-backports/main arm64 libgmock-dev arm64 1.8.0-10~bpo9+1 [217 kB]
Fetched 1071 kB in 0s (2577 kB/s)
Selecting previously unselected package googletest:arm64.
(Reading database ... 138533 files and directories currently installed.)
Preparing to unpack .../googletest_1.8.0-10~bpo9+1_arm64.deb ...
Unpacking googletest:arm64 (1.8.0-10~bpo9+1) ...
Selecting previously unselected package libgtest-dev:arm64.
Preparing to unpack .../libgtest-dev_1.8.0-10~bpo9+1_arm64.deb ...
Unpacking libgtest-dev:arm64 (1.8.0-10~bpo9+1) ...
Selecting previously unselected package libgmock-dev:arm64.
Preparing to unpack .../libgmock-dev_1.8.0-10~bpo9+1_arm64.deb ...
Unpacking libgmock-dev:arm64 (1.8.0-10~bpo9+1) ...
Setting up googletest:arm64 (1.8.0-10~bpo9+1) ...
Setting up libgtest-dev:arm64 (1.8.0-10~bpo9+1) ...
Setting up libgmock-dev:arm64 (1.8.0-10~bpo9+1) ...

Attached Dockerfile of working sonic-stretch build
Dockerfile.txt

@bacrossland
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@bacrossland
Copy link
Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12476 in repo sonic-net/sonic-buildimage

@bacrossland
Copy link
Author

This PR is no longer needed as #12358 was merged with successful build

@bacrossland bacrossland deleted the add-gmock-202012 branch October 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants