Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:16490] Fix potentially not having any loopback address on lo interface #16627

Merged
merged 1 commit into from
Oct 20, 2023

Commits on Sep 21, 2023

  1. Fix potentially not having any loopback address on lo interface (soni…

    …c-net#16490)
    
    In sonic-net#15080, there was a command added to re-add 127.0.0.1/8 to the lo
    interface when the networking configuration is being brought down.
    However, the trigger for that command is `down`, which, looking at
    ifupdown2 configuration files, runs immediately after 127.0.0.1/16 is
    removed. This means there may be a period of time where there are no
    loopback addresses assigned to the lo interface, and redis commands will
    fail.
    
    Fix this by changing this to pre-down, which should run well before
    127.0.0.1/16 is removed, and should always leave lo with a loopback
    address.
    
    Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
    saiarcot895 authored and mssonicbld committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    290afad View commit details
    Browse the repository at this point in the history