-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for CMIS host management feature #18211
Merged
yxieca
merged 4 commits into
sonic-net:master
from
dbarashinvd:dbarashi_indep_mode_unit_test
Mar 20, 2024
Merged
add unit tests for CMIS host management feature #18211
yxieca
merged 4 commits into
sonic-net:master
from
dbarashinvd:dbarashi_indep_mode_unit_test
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrink the code using setup and teardown functions
noaOrMlnx
approved these changes
Feb 29, 2024
@prgeor , Can you please assist with review for this PR ? |
@prgeor , Can you please review ? |
@prgeor , Can you please review this PR ? |
prgeor
approved these changes
Mar 19, 2024
@yxieca , Can you please merge ? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 20, 2024
* add unit tests for CMIS host management feature
Cherry-pick PR to 202311: #18402 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add unit tests for CMIS host management feature
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
add unit tests to test CMIS host management feature
Work item tracking
How I did it
add new file for testing the feature using python unit tests
How to verify it
run all tests from mlnx-platform-api python wheel and make sure all of them passes
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)