[device] Misc fixes for Arista platforms #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two platforms were using a previous version of a kernel driver. The new one names the i2c buses differently. We therefore need to rename them here.
The interface offset is invalid which makes sonic-cfggen generate an invalid config_db.jon in rc.local. This config then silently makes orchagent/syncd fail.
Instead of always assuming /mnt/flash, use the partition where the image to be installed lies. This allow for the image to be on any partition.
lguohan
reviewed
Jul 5, 2018
| @@ -22,20 +22,20 @@ iface lo {{ 'inet' if prefix | ipv4 else 'inet6' }} static | |||
| auto eth0 | |||
| {% if MGMT_INTERFACE %} | |||
| {% for (name, prefix) in MGMT_INTERFACE %} | |||
| iface eth0 {{ 'inet' if prefix | ipv4 else 'inet6' }} static | |||
| iface {{ name }} {{ 'inet' if prefix | ipv4 else 'inet6' }} static | |||
There was a problem hiding this comment.
why do you replace eth0 with {{ name }}? there are lots of places that assume the management port name is eth0. is this assumption broken on arista platform?
There was a problem hiding this comment.
this assumption is not broken.
- Replace eth0 by '{{ name }}' as it should be
- this fix allows to have more than one mgmt interfaces: eth0 + XXX + ...
There was a problem hiding this comment.
can you revert this?
I checked, current the name is Management0, I do not think we should use that.
There was a problem hiding this comment.
Sure, I'll remove this commit.
lguohan
requested changes
Jul 5, 2018
lguohan
approved these changes
Jul 5, 2018
jleveque
approved these changes
Jul 5, 2018
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Aug 8, 2021
* 41dfaad 2021-08-02 | Bridge mac setting, fix statedb time format (sonic-net#1844) (HEAD, origin/202012) [Prince Sunny] Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
added a commit
that referenced
this pull request
Aug 9, 2021
* 41dfaad 2021-08-02 | Bridge mac setting, fix statedb time format (#1844) (HEAD, origin/202012) [Prince Sunny] Signed-off-by: Guohan Lu <lguohan@gmail.com>
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Sep 29, 2021
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (sonic-net#1844) 388c50c [202012][warmboot] Add new preboot health check: verify db integrity (sonic-net#1839) d73dc98 [config] support for configuring muxcable to standby mode of operation (sonic-net#1837) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Sep 30, 2021
0b5f90b (HEAD -> 202012, origin/202012) [show techsupport] fix bash errors in generate_dump script (#1844) 388c50c [202012][warmboot] Add new preboot health check: verify db integrity (#1839) d73dc98 [config] support for configuring muxcable to standby mode of operation (#1837) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
*Set bridge mac same as Vlan mac *Format state_db entries to have six digit precision for microseconds
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
Signed-off-by: Sangita Maity <samaity@linkedin.com> * src/sonic-utilities 9fde08a...595e322 (3): > [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) > [show techsupport] fix bash errors in generate_dump script (sonic-net#1844) > [techsupport] [202012] Removed -i option for docker commands and Improved Error Reporting (sonic-net#1833)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…#1844) What I did Fix: sonic-net#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the i2c bus names for 7050QX-32 and 7050QX-32S after the recent submodule update.
Fix the default minigraph.xml for the 7050QX-32S that prevented it from properly starting.
Allow the image to be booted from another partition which does not affect default behavior.
- How to verify it
Boot an image on 7050QX-32S from vfat to verify that the initramfs script is still working.
Starting without minigraph.xml and verifying that syncd does not crash verifies the default minigraph.xml
Verify that the sensors names are properly set up.
- Description for the changelog
Miscellaneous fixes for Arista devices.