Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[platform][Broadcom]Accton, fix building error of kernel modules. #2197

Conversation

roylee123
Copy link
Collaborator

- What I did
Fix compilation error of kernel modules.

- How I did it
Fix sys_temp of fan of as7712, for driver/hwmon is changed at linux 4.x.
change "char" to "const char " for attribute with write permission.
Remove sys_temp of as7716-32 and as7716-32xb for not used.
Remove non-existing file from Makefile.

- How to verify it
No error on compiling kernel modules and corresponding ko files are formed.
Read sys_temp on as7712-32x under different fan speed.

- Description for the changelog

…oadcom.

Signed-off-by: roy_lee <roy_lee@accton.com>
Signed-off-by: roy_lee <roy_lee@accton.com>
@lguohan lguohan merged commit 483bd9b into sonic-net:master Oct 26, 2018
judyjoseph added a commit that referenced this pull request Apr 4, 2022
5bb99c7 Validate LAG has members before mirror session create (#2130)
ec6c8af [vxlan] Remove tunnel map objects on VNET tunnel removal (#2150)
7e7db19 [BFD]Registering BFD state change callback during session creation (#2202)
618fe07 [VNET]Fixing nexthop group delete during route change (#2198)
91b66df [portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165)
29de9d0 Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197)
ded0b45 [PBH] Implement Edit Flows (#2169)
2ee0f49 [neighsyncd] increase neighsyncd timeout (#2209)
a0160c0 [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (#2206)
stepanblyschak added a commit to stepanblyschak/sonic-buildimage that referenced this pull request Apr 4, 2022
```
323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
vivekrnv added a commit to vivekrnv/sonic-buildimage that referenced this pull request Apr 4, 2022
323dc34 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (sonic-net#2185)

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this pull request Apr 5, 2022
This submodule update brings in the following changes:

```
50d5be2 Make changes to support compiling on Bullseye with GCC 10 (sonic-net#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (sonic-net#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (sonic-net#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
5575935 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
0f06910 [PBH] Implement Edit Flows (sonic-net#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (sonic-net#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (sonic-net#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (sonic-net#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (sonic-net#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (sonic-net#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
2bef62b Validate LAG has members before mirror session create (sonic-net#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (sonic-net#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (sonic-net#2179)
```

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
liat-grozovik pushed a commit that referenced this pull request Apr 6, 2022
```
323dc34 [neighsyncd] increase neighsyncd timeout (#2209)
7f99941 Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197)
f3a0feb [Vxlanmgr] vnet netdev cleanup during config reload fix (#2191)
13ccaba Fix issue: sometimes PFC WD unable to create zero buffer pool (#2185)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
theasianpianist added a commit to theasianpianist/sonic-buildimage that referenced this pull request Apr 6, 2022
50d5be2 (HEAD, origin/master, origin/HEAD) Make changes to support compiling on Bullseye with GCC 10 (sonic-net#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (sonic-net#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (sonic-net#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (sonic-net#2206)
5575935 [neighsyncd] increase neighsyncd timeout (sonic-net#2209)
0f06910 (master) [PBH] Implement Edit Flows (sonic-net#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (sonic-net#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (sonic-net#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (sonic-net#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (sonic-net#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (sonic-net#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (sonic-net#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (sonic-net#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (sonic-net#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (sonic-net#2191)
2bef62b Validate LAG has members before mirror session create (sonic-net#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (sonic-net#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (sonic-net#2179)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
liat-grozovik pushed a commit that referenced this pull request Apr 7, 2022
In order to include the following commit:
0f06910 [PBH] Implement Edit Flows (sonic-net/sonic-swss#2169)

sonic-swss

50d5be2 Make changes to support compiling on Bullseye with GCC 10 (#2216)
0870cf5 [mirrororch]: Implement HW resources availability validation for SPAN/ERSPAN (#2187)
f4ec565 [vlanmgrd] fix use-after-free memory issue (#2211)
c2de7fc [QosOrch] The notifications cannot be drained in QosOrch in case the first one needs to retry (#2206)
5575935 [neighsyncd] increase neighsyncd timeout (#2209)
0f06910 [PBH] Implement Edit Flows (#2169)
6241bbf Remove redundant and problematic code to skip "pool" field in buffer profile handling (#2197)
a55343c [azp]: Set diff coverage threshhold to 80% (#2188)
390cae1 [portsorch]: Prevent LAG member configuration when port has active ACL binding (#2165)
c1d47e6 [VNET]Fixing nexthop group delete during route change (#2198)
8941cc0 [BFD]Registering BFD state change callback during session creation (#2202)
680c539 [vxlan] Remove tunnel map objects on VNET tunnel removal (#2150)
20dde0c Fix for handling broadcom DNX ASIC to have ipv4 and ipv6 ACL rules in separate tables. (#2178)
5b7c949 [FdbOrch] SAI_FDB_EVENT_MOVE generates update with empty update.entry.port_name (#2200)
7350d49 [Vxlanmgr] vnet netdev cleanup during config reload fix (#2191)
2bef62b Validate LAG has members before mirror session create (#2130)
1e4d4ce [VS test] Increase VS test time, skip dpb flaky test (#2195)
6eda965 [vstest]Migrating vs tests from using click commands to direct DB access (#2179)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Ndancejic pushed a commit to Ndancejic/sonic-buildimage that referenced this pull request May 3, 2022
…profile handling (sonic-net#2197)

- What I did
Remove redundant and problematic code to skip "pool" field in buffer profile handling

- Why I did it
When a buffer profile is modified, the snippet of code skipped "pool" field handling without pool's name being parsed, which broke the dependency tracing logic.
In a rare scenario, if buffer orchagent receives a notification to remove the pool before removing the profile, it can cause the buffer pool to be removed when it is still referenced.

- How I verified it
Manually and regression test.

Signed-off-by: Stephen Sun <stephens@nvidia.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
liat-grozovik pushed a commit that referenced this pull request Jul 28, 2022
feeac84 [counters] Keep counters cache in a single directory (#2232)
cd7909e Updated the CLI file for Radius and Linux kernel commands (#2276)
cd6898b Update db_migrator to support `PORT_QOS_MAP|global` (#2205)
8f4fc62 Revert "Revert "[scripts/fast-reboot] Shutdown remaining containers through systemd (#2133)" (#2161)" (#2184)
27667cf Fix test for pfcwd_sw_enable in db_migrator_test (#2253)
e1866e3 [MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform (#2258)
9e3ba82 Change db_migrator major version on master branch from version 2 to 3 (#2272)
65346ce Microsoft mandatory file (#2177)
308e25f portconfig option to configure Tx power and laser frequency of ZR transceiver module (#2197)
e49b1e8 [vnet_route_check] Align DB data parse logic with format used by swsscommon API (#2268)

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Aug 27, 2022
… advance submodule head

linkmgrd:
* 9a993b2 2022-08-23 | [active-active] Remove unnecessary mux wait timeout logs (sonic-net#122) (HEAD -> 202205) [Jing Zhang]

utilities:
* ec4b09f 2022-08-26 | Handle non-front-panel ports in is_rj45_port (sonic-net#2327) (HEAD -> 202205, github/202205) [Stephen Sun]
* 4adf897 2022-08-20 | Fix issue: port_type is referenced before initialized (sonic-net#2323) [Stephen Sun]
* 314bafd 2022-08-25 | [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (sonic-net#2319) [Ze Gan]
* e0166a0 2022-08-25 | portconfig option to configure Tx power and laser frequency of ZR transceiver module (sonic-net#2197) (sonic-net#2330) [Prince George]

swss-common:
* af80c12 2022-06-30 | [select] break the select loop if interrupt_on_signal flag is set (sonic-net#624) (HEAD -> 202205, github/202205) [Stepan Blyshchak]

sairedis:
* a1796a5 2022-07-28 | Add support of mdio IPC server class using sai switch api and unix socket (sonic-net#1080) (HEAD -> 202205) [Jiahua Wang]

platform-common:
* c1ee4b1 2022-08-20 | [CMIS] Catch Exception to avoid CMIS code crash (sonic-net#299) (HEAD -> 202205) [Kebo Liu]
* 638d225 2022-07-13 | Fix Cmis memmap field offset (sonic-net#290) [Prince George]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca added a commit that referenced this pull request Aug 29, 2022
… advance submodule head (#11859)

linkmgrd:
* 9a993b2 2022-08-23 | [active-active] Remove unnecessary mux wait timeout logs (#122) (HEAD -> 202205) [Jing Zhang]

utilities:
* ec4b09f 2022-08-26 | Handle non-front-panel ports in is_rj45_port (#2327) (HEAD -> 202205, github/202205) [Stephen Sun]
* 4adf897 2022-08-20 | Fix issue: port_type is referenced before initialized (#2323) [Stephen Sun]
* 314bafd 2022-08-25 | [service_mgmt]: Fix fetch MULTI_INST_DEPENDENT bug in service_mgmt.sh.j2 (#2319) [Ze Gan]
* e0166a0 2022-08-25 | portconfig option to configure Tx power and laser frequency of ZR transceiver module (#2197) (#2330) [Prince George]

swss-common:
* af80c12 2022-06-30 | [select] break the select loop if interrupt_on_signal flag is set (#624) (HEAD -> 202205, github/202205) [Stepan Blyshchak]

sairedis:
* a1796a5 2022-07-28 | Add support of mdio IPC server class using sai switch api and unix socket (#1080) (HEAD -> 202205) [Jiahua Wang]

platform-common:
* c1ee4b1 2022-08-20 | [CMIS] Catch Exception to avoid CMIS code crash (#299) (HEAD -> 202205) [Kebo Liu]
* 638d225 2022-07-13 | Fix Cmis memmap field offset (#290) [Prince George]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants