Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bde driver] black list linux_kernel_bde driver #2284

Merged
merged 1 commit into from
Nov 21, 2018
Merged

[bde driver] black list linux_kernel_bde driver #2284

merged 1 commit into from
Nov 21, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Nov 20, 2018

Signed-off-by: Ying Xie ying.xie@microsoft.com

- What I did
This driver should be loaded by sonic service. If kernel tries to load
it, the driver would be loaded with default parameters, which is not
right for sonic.

@yxieca
[bde driver] black list linux_kernel_bde driver
9c58979 
This driver should be loaded by sonic service. If kernel tries to load
it, the driver would be loaded with default parameters, which is not
right for sonic.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca requested review from lguohan and jleveque November 20, 2018 21:37
jipanyang
jipanyang reviewed Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@jipanyang jipanyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the other two: linux-user-bde & linux-bcm-knet? Though they depend on linux-kernel-bde, will kernel try to load them too?

zhenggen-xu
zhenggen-xu reviewed Nov 21, 2018
View reviewed changes
files/image_config/platform/linux_kernel_bde.conf
@@ -0,0 +1 @@
blacklist linux_kernel_bde
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who is trying to load linux_kernel_bde if we are not running sonic service?
backlist does not prevent it from being loaded as a dependency for another kernel module that is not blacklisted, are there any other modules depending on this module that could still start this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is automatically loaded by kernel based on the pcie id. @jipanyang , user-bde and bnet bde are not pci driver, they will not be automatically loaded.

@yxieca yxieca merged commit 873df9d into sonic-net:master Nov 21, 2018
@yxieca yxieca deleted the blacklist branch November 21, 2018 16:08
lguohan pushed a commit that referenced this pull request Mar 18, 2019
@yxieca @lguohan
[bde driver] black list linux_kernel_bde driver (#2284)
b38bab0 
This driver should be loaded by sonic service. If kernel tries to load
it, the driver would be loaded with default parameters, which is not
right for sonic.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Aug 6, 2022
@stephenxs
Advance sonic-utilities pointer
a30655f 
7919077f Add FEC correctable and uncorrectable port stats (sonic-net#2027)
ecb91367 Add CLI to configure YANG config validation (sonic-net#2147)
e9ab5235 Add override testcase to verify removal (sonic-net#2288)
c6794b55 Fix version in db_migrator  for `PORT_QOS_MAP|global` (sonic-net#2289)
92b889b7 [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB (sonic-net#2223)
dab0d065 Transfer organization from Azure to sonic-net (sonic-net#2284)
6de18a1d [watermarkstat] Fix CLI script for unconfigured PG counters (sonic-net#2239)
ac2f5530 Improve the way to check port type of RJ45 port (sonic-net#2249)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs added a commit to stephenxs/sonic-buildimage that referenced this pull request Aug 8, 2022
@stephenxs
Advance sonic-utilities pointer
9ea4b31 
7919077f Add FEC correctable and uncorrectable port stats (sonic-net#2027)
ecb91367 Add CLI to configure YANG config validation (sonic-net#2147)
e9ab5235 Add override testcase to verify removal (sonic-net#2288)
c6794b55 Fix version in db_migrator  for `PORT_QOS_MAP|global` (sonic-net#2289)
92b889b7 [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB (sonic-net#2223)
dab0d065 Transfer organization from Azure to sonic-net (sonic-net#2284)
6de18a1d [watermarkstat] Fix CLI script for unconfigured PG counters (sonic-net#2239)
ac2f5530 Improve the way to check port type of RJ45 port (sonic-net#2249)
142185c9 Fix the issue that sonic_platform is not installed on vs image (sonic-net#2300)
ca14133f [crm] add checking for CRM interval range (sonic-net#2293)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 9, 2022
@dprital
[submodule] Update sonic-utilities submodule
622adec 
Update sonic-utilities submodule pointer to include the following:
* Fix GCU bug when backend service modifying config ([sonic-net#2295](sonic-net/sonic-utilities#2295))
* Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker ([sonic-net#2278](sonic-net/sonic-utilities#2278))
* [crm] add checking for CRM interval range ([sonic-net#2293](sonic-net/sonic-utilities#2293))
* Fix the issue that sonic_platform is not installed on vs image ([sonic-net#2300](sonic-net/sonic-utilities#2300))
* Add FEC correctable and uncorrectable port stats ([sonic-net#2027](sonic-net/sonic-utilities#2027))
* Add CLI to configure YANG config validation ([sonic-net#2147](sonic-net/sonic-utilities#2147))
* Add override testcase to verify removal ([sonic-net#2288](sonic-net/sonic-utilities#2288))
* Fix version in db_migrator  for  ([sonic-net#2289](sonic-net/sonic-utilities#2289))
* [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB ([sonic-net#2223](sonic-net/sonic-utilities#2223))
* Transfer organization from Azure to sonic-net ([sonic-net#2284](sonic-net/sonic-utilities#2284))
* [watermarkstat] Fix CLI script for unconfigured PG counters ([sonic-net#2239](sonic-net/sonic-utilities#2239))
* Improve the way to check port type of RJ45 port ([sonic-net#2249](sonic-net/sonic-utilities#2249))

Signed-off-by: dprital <drorp@nvidia.com>
prgeor pushed a commit that referenced this pull request Aug 10, 2022
@stephenxs
[submodule] Advance sonic-swss and sonic-utilities pointer (#11643)
0a203ba 
* Advance sonic-utilities pointer

7919077f Add FEC correctable and uncorrectable port stats (#2027)
ecb91367 Add CLI to configure YANG config validation (#2147)
e9ab5235 Add override testcase to verify removal (#2288)
c6794b55 Fix version in db_migrator  for `PORT_QOS_MAP|global` (#2289)
92b889b7 [intfutil] Check whether the FEC mode is supported on the platform before configuring it to CONFIG_DB (#2223)
dab0d065 Transfer organization from Azure to sonic-net (#2284)
6de18a1d [watermarkstat] Fix CLI script for unconfigured PG counters (#2239)
ac2f5530 Improve the way to check port type of RJ45 port (#2249)
142185c9 Fix the issue that sonic_platform is not installed on vs image (#2300)
ca14133f [crm] add checking for CRM interval range (#2293)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* Advance swss

dc8bc1c [portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (#2333)
6565b50 Revert "[portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (#2333)" (#2396)
dc88d55 Revert hwinfo count change (#2383)
75fc965 [DualToR] Handle race condition between tunnel_decap and mux orchestrator (#2397)
525a57f Fix for remote system interface not getting created (#2364)
3161eaa portsorch: initial support for link-training (#2359)
dc477fb [swss/cfgmgr] teammgr configure lacp rate (#2121)
2489ad5 Improve pytest speend by grouping 20 tests together. (#2390)
168bd3b [EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow (#2404)
1e1438e [portsorch] Expose supported FEC modes to STABE_DB and check whether FEC mode is supported before setting it (#2400)
9f2e27b [QoS] Fix issue: the WRED profile can not be set if current min > new max or current max < new min (#2379)
d36c17d [asan][aclorch] fix a memory leak in the SaiAttrWrapper::swap() (#2382)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

* More sonic-utilities PRs

be1866fd Fix GCU bug when backend service modifying config (#2295)
bcf36eb3 Fix issues for sonic_installer upgrade-docker and sonic_installer rollback-docker (#2278)

Signed-off-by: Stephen Sun <stephens@nvidia.com>

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@aravindmani-1 aravindmani-1 mentioned this pull request Nov 18, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jipanyang jipanyang jipanyang left review comments

@zhenggen-xu zhenggen-xu zhenggen-xu left review comments

@stcheng stcheng stcheng approved these changes

@lguohan lguohan lguohan approved these changes

@jleveque jleveque Awaiting requested review from jleveque

Assignees
No one assigned
Labels
Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yxieca @lguohan @stcheng @zhenggen-xu @jipanyang