Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y #2702

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

stepanblyschak
Copy link
Collaborator

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

- What I did
Install debug packages when INSTALL_DEBUG_TOOLS=y, the same way as with swss docker image;

- How to verify it
Installed docker syncd(rpc) image on DUT built with SONIC_DEBUGGING_ON=y and INSTALL_DEBUG_TOOLS=y

root@arc-switch1025:/# dpkg --list | grep dbg

ii  libsaimetadata-dbg          1.0.0                          amd64        debugging symbols for libsaimetadata
ii  libsairedis-dbg             1.0.0                          amd64        debugging symbols for libsairedis
ii  libswsscommon-dbg           1.0.0                          amd64        debugging symbols for libswsscommon library.
ii  syncd-rpc-dbg               1.0.0                          amd64        debugging symbols for syncd-rpc

- Description for the changelog
[buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@yxieca
Copy link
Contributor

yxieca commented Mar 26, 2019

I don't think all SAI comes with dbg packet available. These SAI open sourced and built with sonic-buildimage will more likely have access to the dbg packet. But not others, e.g. Broadcom SAI doesn't have dbg packet available. You might want to remove this feature from these flavors of SAI.

@stepanblyschak
Copy link
Collaborator Author

@yxieca This change does not install dbg packages for SAI vendor implementation;
libsairedis-dbg and libsaimetadata-dbg come from sairedis sources

@stepanblyschak
Copy link
Collaborator Author

retest this please

1 similar comment
@stepanblyschak
Copy link
Collaborator Author

retest this please

@lguohan lguohan requested a review from renukamanavalan March 28, 2019 01:33
@lguohan
Copy link
Collaborator

lguohan commented Mar 30, 2019

@renukamanavalan , can you give your comments here?

@yxieca
Copy link
Contributor

yxieca commented Apr 1, 2019

@stepanblyschak I see. thanks.

@@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}}
{%- endfor -%}
debs/

RUN dpkg -P syncd
RUN apt-get remove -y syncd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use apt-get purge?

@@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}}
{%- endfor -%}
debs/

RUN dpkg -P syncd
RUN apt-get remove -y syncd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

@@ -9,7 +9,7 @@ debs/{{ deb }}{{' '}}
{%- endfor -%}
debs/

RUN dpkg -P syncd
RUN apt-get remove -y syncd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same

@lguohan
Copy link
Collaborator

lguohan commented Apr 4, 2019

purge is cleaner.

Stepan Blyschak and others added 2 commits April 4, 2019 13:34
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@lguohan lguohan merged commit ea078e7 into sonic-net:master Apr 18, 2019
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
…S=y (sonic-net#2702)

* [buildsystem] Install debug packages in syncd when INSTALL_DEBUG_TOOLS=y

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@stepanblyschak stepanblyschak deleted the syncd_dbg branch September 23, 2022 13:32
prsunny added a commit that referenced this pull request Mar 29, 2023
Update for swss following commits:
3108985 - 2023-03-28 : [202012][muxorch] handling multiple mux nexthops for route (#2702) [Nikola Dancejic]
f412625 - 2023-03-24 : [202012]Custom monitoring based priority tunnels (#2671) [siqbal1986]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants