[build]: Add missing 'rm -rf' to component Makefiles for clean rebuild #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/iproute2/Makefile * src/python3/Makefile These Makefiles do not properly clean out the src build subdirectory prior to downloading the source code contents. This causes an error during a rebuild following a 'make clean'. Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
|
|
jleveque
approved these changes
Jun 18, 2019
|
Retest vs please |
|
thanks! |
lguohan
pushed a commit
that referenced
this pull request
Jun 19, 2019
#3028) * src/iproute2/Makefile * src/python3/Makefile These Makefiles do not properly clean out the src build subdirectory prior to downloading the source code contents. This causes an error during a rebuild following a 'make clean'. Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
sonic-net#3028) * src/iproute2/Makefile * src/python3/Makefile These Makefiles do not properly clean out the src build subdirectory prior to downloading the source code contents. This causes an error during a rebuild following a 'make clean'. Signed-off-by: Greg Paussa <greg.paussa@broadcom.com>
mssonicbld
added a commit
that referenced
this pull request
Nov 15, 2023
…atically (#17173) #### Why I did it src/sonic-utilities ``` * 3609e417 - (HEAD -> 202305, origin/202305) [sonic-package-manager] do not modify config_db.json (#3032) (2 hours ago) [Stepan Blyshchak] * 354dfe80 - [sonic_installer]: Improve exception handling: introduce notes. (#3028) (3 hours ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Feb 8, 2024
…lly (#18070) #### Why I did it src/sonic-swss ``` * b3b6a838 - (HEAD -> master, origin/master, origin/HEAD) [test_mux] Multi-mux-nh full test coverage (#3028) (25 minutes ago) [Nikola Dancejic] * 3bd01444 - Bfd support for TSA state. (#2926) (6 hours ago) [siqbal1986] ``` #### How I did it #### How to verify it #### Description for the changelog
sonic-otn
pushed a commit
to Weitang-Zheng/sonic-buildimage
that referenced
this pull request
Mar 11, 2024
…lly (sonic-net#18070) #### Why I did it src/sonic-swss ``` * b3b6a838 - (HEAD -> master, origin/master, origin/HEAD) [test_mux] Multi-mux-nh full test coverage (sonic-net#3028) (25 minutes ago) [Nikola Dancejic] * 3bd01444 - Bfd support for TSA state. (sonic-net#2926) (6 hours ago) [siqbal1986] ``` #### How I did it #### How to verify it #### Description for the changelog
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Mar 12, 2024
…lly (sonic-net#18070) #### Why I did it src/sonic-swss ``` * b3b6a838 - (HEAD -> master, origin/master, origin/HEAD) [test_mux] Multi-mux-nh full test coverage (sonic-net#3028) (25 minutes ago) [Nikola Dancejic] * 3bd01444 - Bfd support for TSA state. (sonic-net#2926) (6 hours ago) [siqbal1986] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These Makefiles do not properly clean out the src build subdirectory
prior to downloading the source code contents. This causes an error
during a rebuild following a 'make clean'.
Signed-off-by: Greg Paussa greg.paussa@broadcom.com
- What I did
Fixed a problem with doing a rebuild from a SONiC local clone following a 'make clean'. The following is a typical error that occurs in this scenario:
- How I did it
Added the missing 'rm -rf' command to the src/iproute2 and src/python3 Makefiles. All other non-submodule component Makefiles follow a similar pattern, namely they remove their entire build subdirectory prior to fetching their source code contents (wget, git clone, etc.) so that the build can start from a clean slate. There were three components that did not first remove their source build subdirectory, causing a build error on a subsequent rebuild following a 'make clean'. Of these, the src/lldpd/Makefile was fixed in a previous commit 1e3b62fe. This PR covers the remaining two that were found by visual inspection of the Makefiles.
- How to verify it
This is typically seen when doing a rebuild following a previous build. Assuming 'make init' and 'make configure' have already been done, this sequence exposes the python3 build error (shown above) for the broadcom platform:
A more direct way to observe the issue is:
- Description for the changelog
Add missing 'rm -rf' command to src/iproute2/Makefile and src/python3/Makefile to allow clean rebuild.
- A picture of a cute animal (not mandatory but encouraged)