Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mellanox] Fix the memory leak in mlnx-sfpd #3128

Merged
merged 2 commits into from
Jul 9, 2019
Merged

[Mellanox] Fix the memory leak in mlnx-sfpd #3128

merged 2 commits into from
Jul 9, 2019

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Jul 8, 2019 •
edited
Loading

- What I did
Fix the memory leak in mlnx-sfpd.

- How I did it
Fix the memory leak in mlnx-sfpd::on_pmpe.

- How to verify it
reset an SFP module, and then:

  1. observe /proc/<pid of mlnx-sfpd>/maps and check whether [heap] increases.
  2. observe syslog and check whether SFP module plugin/out event has been recorded.

- Description for the changelog
[Mellanox] Fix the memory leak in mlnx-sfpd

- A picture of a cute animal (not mandatory but encouraged)

fix the memory leak in on_pmpe. objects created via sx_api having con…
559c62b 
…vention new_<type_name> should be release explicitly via delete_<type_name>.
@stephenxs stephenxs marked this pull request as ready for review July 8, 2019 11:34
@lguohan
Copy link
Collaborator

lguohan commented Jul 8, 2019

@jleveque , we should do pmon memory limit so that it won't impact other services in sonic.

@lguohan
Copy link
Collaborator

lguohan commented Jul 8, 2019

can you identify which branch are affected?

@keboliu
Copy link
Collaborator

keboliu commented Jul 9, 2019

can you identify which branch are affected?
@lguohan @stephenxs this issue affect 201807 and above, for 201807 need a dedicated PR since the code was refactored since 201811. for 201811 and above can cherry-pick.

@stephenxs
Copy link
Collaborator Author

can you identify which branch are affected?
@lguohan @stephenxs this issue affect 201807 and above, for 201807 need a dedicated PR since the code was refactored since 201811. for 201811 and above can cherry-pick.

PR#3131 for 201807

@liat-grozovik liat-grozovik self-assigned this Jul 9, 2019
@liat-grozovik liat-grozovik merged commit cca115d into sonic-net:master Jul 9, 2019
@stephenxs stephenxs deleted the fix-mlnx-sfpd-leak branch July 9, 2019 14:51
yxieca pushed a commit that referenced this pull request Jul 10, 2019
@stephenxs @yxieca
[Mellanox] Fix the memory leak in mlnx-sfpd (#3128)
0c77acf 
* fix the memory leak in on_pmpe. objects created via sx_api having convention new_<type_name> should be release explicitly via delete_<type_name>.

* avoid duplicate code.
mssonicbld added a commit that referenced this pull request May 2, 2024
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
80fc331 
…lly (#18847)

#### Why I did it
src/sonic-swss
```
* 2e6c5b20 - (HEAD -> master, origin/master, origin/HEAD) [DropCounter]Fix the ordering issue with dropcounter (#3128) (4 hours ago) [Sudharsan Dhamal Gopalarathnam]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jun 15, 2024
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
a334777 
…lly (#19320)

#### Why I did it
src/sonic-swss
```
* c0670b7f - (HEAD -> 202311, origin/202311) [DropCounter]Fix the ordering issue with dropcounter (#3128) (64 minutes ago) [Sudharsan Dhamal Gopalarathnam]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

@jleveque jleveque jleveque approved these changes

@lguohan lguohan lguohan approved these changes

Assignees

@liat-grozovik liat-grozovik

Labels
Bug 🐛 Included in 201811 Branch Platform: Mellanox Request for 201811 Branch :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stephenxs @lguohan @keboliu @jleveque @stcheng @yxieca @liat-grozovik