-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneimage] Check if graph service address got from dhcp is valid url #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Feb 23, 2017
@@ -29,9 +29,14 @@ if [ "$src" = "dhcp" ]; then | |||
|
|||
HOSTNAME=`hostname -s` | |||
GRAPH_URL=`sonic-cfggen -t /tmp/dhcp_graph_url -a "{\"hostname\": \"$HOSTNAME\"}"` | |||
URL_REGEX='^(https?|ftp|file)://[-A-Za-z0-9\+&@#/%?=~_|!:,.;]*[-A-Za-z0-9\+&@#/%=~_|]$' | |||
if [[ ! $GRAPH_URL =~ $URL_REGEX ]]; then | |||
echo "Invalid graph url. Skipping graph update." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print out the url for debug purpose
lguohan
approved these changes
Feb 23, 2017
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Oct 14, 2018
* 6d00d14 2018-10-13 | pfcwd cmd check (sonic-net#342) (HEAD, origin/master, origin/HEAD) [Wenda Ni] * eb92560 2018-10-12 | [show] Refactor show vlan brief to use configdb and update the output (sonic-net#340) [Deva Nandhagopal] * 9a139ab 2018-10-10 | Remove explicit dependency on tabulate; Add comments (sonic-net#336) [Joe LeVeque] * 7874b8f 2018-10-09 | Update restart_count to restore_count for warm restart (sonic-net#326) [Jipan Yang] * 7a51a85 2018-10-08 | [acl_loader] fix show acl table (sonic-net#329) [ironjosh] * 54ebfc8 2018-10-05 | Add a "-l/--load-sysinfo" option for "config reload" to merge the system info on device (sonic-net#324) [zhenggen-xu] * 34810df 2018-10-05 | [show] Eliminate need for writing template files for 'show platform summary' and 'show version' (sonic-net#335) [Joe LeVeque] * 4258287 2018-10-05 | Added argument forwarder for platform reboot. (sonic-net#333) [Nazarii Hnydyn] * e2b4bd5 2018-10-03 | Warm reboot: Add support for docker upgrade (sonic-net#292) [Jipan Yang] * f1236aa 2018-10-01 | Root priviliege for ecn configuration set commands (sonic-net#332) [Wenda Ni] * 3098b8a 2018-10-01 | require root privilege for all pfcwd configuration commands (sonic-net#330) [lguohan] * 7627d08 2018-09-27 | [config]: Add portchannel related commands (sonic-net#328) [Shuotian Cheng] * b8a62d7 2018-09-27 | Add 'alias mode' support for show commands (sonic-net#298) [paavaanan] * 4383300 2018-09-26 | [aclshow]: Fix the KeyError issue in aclshow (sonic-net#325) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan
added a commit
that referenced
this pull request
Oct 14, 2018
* 6d00d14 2018-10-13 | pfcwd cmd check (#342) (HEAD, origin/master, origin/HEAD) [Wenda Ni] * eb92560 2018-10-12 | [show] Refactor show vlan brief to use configdb and update the output (#340) [Deva Nandhagopal] * 9a139ab 2018-10-10 | Remove explicit dependency on tabulate; Add comments (#336) [Joe LeVeque] * 7874b8f 2018-10-09 | Update restart_count to restore_count for warm restart (#326) [Jipan Yang] * 7a51a85 2018-10-08 | [acl_loader] fix show acl table (#329) [ironjosh] * 54ebfc8 2018-10-05 | Add a "-l/--load-sysinfo" option for "config reload" to merge the system info on device (#324) [zhenggen-xu] * 34810df 2018-10-05 | [show] Eliminate need for writing template files for 'show platform summary' and 'show version' (#335) [Joe LeVeque] * 4258287 2018-10-05 | Added argument forwarder for platform reboot. (#333) [Nazarii Hnydyn] * e2b4bd5 2018-10-03 | Warm reboot: Add support for docker upgrade (#292) [Jipan Yang] * f1236aa 2018-10-01 | Root priviliege for ecn configuration set commands (#332) [Wenda Ni] * 3098b8a 2018-10-01 | require root privilege for all pfcwd configuration commands (#330) [lguohan] * 7627d08 2018-09-27 | [config]: Add portchannel related commands (#328) [Shuotian Cheng] * b8a62d7 2018-09-27 | Add 'alias mode' support for show commands (#298) [paavaanan] * 4383300 2018-09-26 | [aclshow]: Fix the KeyError issue in aclshow (#325) [Shuotian Cheng] Signed-off-by: Guohan Lu <gulv@microsoft.com>
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
…tem info on device (sonic-net#324) The information includes: -- platform string -- system mac -- port configuration: alias, lanes, speed, index This is useful when we first load the configuration from config_db.json generated outside which does not have the information on the device. The default behaviour is not changed, so it won't impact the system unless you use this option. This can be used for ZTP to config the box the first time and avoid any addtional work which could cause inconsistency.
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…net#324) Signed-off-by: Volodymyr Samotiy <volodymyrs@mellanox.com>
7 tasks
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Dec 12, 2022
…ce submodule head linkmgrd: * d7bf12b 2022-12-08 | update link prober stats post logic (sonic-net#159) (HEAD -> 202205) [Jing Zhang] * 1f28c08 2022-12-08 | [Active-Active] remove chatty messages (sonic-net#158) [Jing Zhang] sairedis: * 6a64b85 2022-12-07 | Initialize attr variables in Legacy.switch_get and LegacyFdbEntry.fdb_entry_get (sonic-net#1169) (HEAD -> 202205) [Saikrishna Arcot] platform-daemons: * fb4b158 2022-12-08 | [thermalctld] fix some redundant removal of state DB tables (sonic-net#315) (HEAD -> 202205) [vdahiya12] platform-common: * 9170877 2022-12-04 | [syseeprom] Remove the trailing space in the value of VENDOR_EXT field in the eepromTlvInfo decode (sonic-net#333) (HEAD -> 202205, github/202205) [Marty Y. Lok] * 79a36e2 2022-12-02 | [202205] Add media assignment options to Application Advertisement (sonic-net#324) (sonic-net#329) [Junchao-Mellanox] * b20896c 2022-12-02 | [Ci] Upgrade to bullseye and fix the branch reference issue (sonic-net#332) [xumia] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Dec 13, 2022
…ce submodule head (#13031) linkmgrd: * d7bf12b 2022-12-08 | update link prober stats post logic (#159) (HEAD -> 202205) [Jing Zhang] * 1f28c08 2022-12-08 | [Active-Active] remove chatty messages (#158) [Jing Zhang] sairedis: * 6a64b85 2022-12-07 | Initialize attr variables in Legacy.switch_get and LegacyFdbEntry.fdb_entry_get (#1169) (HEAD -> 202205) [Saikrishna Arcot] platform-daemons: * fb4b158 2022-12-08 | [thermalctld] fix some redundant removal of state DB tables (#315) (HEAD -> 202205) [vdahiya12] platform-common: * 9170877 2022-12-04 | [syseeprom] Remove the trailing space in the value of VENDOR_EXT field in the eepromTlvInfo decode (#333) (HEAD -> 202205, github/202205) [Marty Y. Lok] * 79a36e2 2022-12-02 | [202205] Add media assignment options to Application Advertisement (#324) (#329) [Junchao-Mellanox] * b20896c 2022-12-02 | [Ci] Upgrade to bullseye and fix the branch reference issue (#332) [xumia] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
…c-net#324) * [sfp] Add media assignment options to Application Advertisement * Increase UT coverage
mssonicbld
added a commit
that referenced
this pull request
Aug 7, 2023
…tomatically (#16059) #### Why I did it src/sonic-linux-kernel ``` * bf1ee0e - (HEAD -> 202305, origin/202305) Fix Makefile syntax and provide default value for CONFIGURED_PLATFORM (#324) (13 hours ago) [Saikrishna Arcot] * 7d7abaf - Update codeowner and build info (#319) (13 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
shanshri
pushed a commit
to shanshri/sonic-buildimage-sonic-net
that referenced
this pull request
Oct 24, 2023
…sonic-net#324) Fix the assignment syntax for SECURE_UPGRADE_SIGNING_CERT. Also, provide a default value for CONFIGURED_PLATFORM, since that's used in the call to manage-config Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
11 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 17, 2024
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
#### Why I did it Update sonic-snmpagent submodule to include below commit: a281f9a [ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (sonic-net#322) d532923 Modify path of python-wheels package to use bookworm (sonic-net#324)
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
#### Why I did it Update sonic-snmpagent submodule to include below commit: a281f9a [ciscoPfcExtMIB]: Remove returning first intf index if subid is empty (sonic-net#322) d532923 Modify path of python-wheels package to use bookworm (sonic-net#324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.