-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] Add a new Mellanox platform x86_64-mlnx_msn4700 and new SKU ACS-MSN4700 #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest this please |
Retest vsimage please |
Retest vsimage please |
liat-grozovik
requested changes
Dec 23, 2019
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/port_config.ini
Outdated
Show resolved
Hide resolved
liat-grozovik
previously approved these changes
Jan 21, 2020
retest vs please |
nazariig
suggested changes
Jan 21, 2020
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/pg_profile_lookup.ini
Outdated
Show resolved
Hide resolved
nazariig
approved these changes
Jan 22, 2020
retest vsimage please |
nazariig
suggested changes
Jan 29, 2020
nazariig
suggested changes
Jan 30, 2020
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/buffers_defaults_t1.j2
Outdated
Show resolved
Hide resolved
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/buffers_defaults_t0.j2
Outdated
Show resolved
Hide resolved
retest vsimage please |
…e into new-sku-msn-4700 Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/psu.py platform/mellanox/mlnx-platform-api/sonic_platform/thermal.py
stephenxs
reviewed
Feb 22, 2020
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/buffers_defaults_t1.j2
Show resolved
Hide resolved
update SAI profile to use 100G X 4lanes for now update port_config.ini according to the SAI profile
[Mellanox]New sku msn4700 new buffer size
nazariig
reviewed
Mar 10, 2020
device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/pg_profile_lookup.ini
Outdated
Show resolved
Hide resolved
…lookup.ini Co-Authored-By: Nazarii Hnydyn <nazariig@mellanox.com>
nazariig
previously approved these changes
Mar 10, 2020
stephenxs
previously approved these changes
Mar 10, 2020
retest this please |
retest vsimage please |
keboliu
commented
Mar 13, 2020
retest this please |
retest vsimage please |
1 similar comment
retest vsimage please |
stephenxs
approved these changes
Mar 19, 2020
nazariig
approved these changes
Mar 19, 2020
liat-grozovik
approved these changes
Mar 22, 2020
@jleveque can you please check if your comments were addressed and you can approve it? |
jleveque
approved these changes
Mar 22, 2020
abdosi
pushed a commit
that referenced
this pull request
Mar 24, 2020
…U ACS-MSN4700 (#3901) * add MSN4700 device files * update ACS-MSN4700 sai profile * update buffer pool size, headroom, sensor conf, port config and reboot scripts * fix ident * update sensor conf and buffer pool * [sn4700] add sku 4700 to chassis.py * [Mellanox-4700] Add 4700 info to psu and thermal platform API * update buffer config file template to the latest. update SAI profile to use 100G X 4lanes for now update port_config.ini according to the SAI profile * [Mellanox]Update the buffer configurations for 4700 * fix alignment in pg_profile_lookup.ini * add platform components file for new sku * Update device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/pg_profile_lookup.ini Co-Authored-By: Nazarii Hnydyn <nazariig@mellanox.com> * remove redundant line * [Mellanox]Correct type, buffer size Co-authored-by: Nazarii Hnydyn <nazariig@mellanox.com> Co-authored-by: junchao <junchao@mellanox.com> Co-authored-by: Stephen Sun <stephens@mellanox.com>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…U ACS-MSN4700 (sonic-net#3901) * add MSN4700 device files * update ACS-MSN4700 sai profile * update buffer pool size, headroom, sensor conf, port config and reboot scripts * fix ident * update sensor conf and buffer pool * [sn4700] add sku 4700 to chassis.py * [Mellanox-4700] Add 4700 info to psu and thermal platform API * update buffer config file template to the latest. update SAI profile to use 100G X 4lanes for now update port_config.ini according to the SAI profile * [Mellanox]Update the buffer configurations for 4700 * fix alignment in pg_profile_lookup.ini * add platform components file for new sku * Update device/mellanox/x86_64-mlnx_msn4700-r0/ACS-MSN4700/pg_profile_lookup.ini Co-Authored-By: Nazarii Hnydyn <nazariig@mellanox.com> * remove redundant line * [Mellanox]Correct type, buffer size Co-authored-by: Nazarii Hnydyn <nazariig@mellanox.com> Co-authored-by: junchao <junchao@mellanox.com> Co-authored-by: Stephen Sun <stephens@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add a new Mellanox platform x86_64-mlnx_msn4700 and new SKU ACS-MSN4700.
- How I did it
Add related files to the device folder:
- How to verify it
run test on the Mellanox simx platform.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)