[BFN] Fix syncd RPC compilation #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft, @kcudnik Please review |
akokhan
previously approved these changes
Mar 12, 2020
qiluo-msft
previously approved these changes
Mar 12, 2020
qiluo-msft
reviewed
Mar 12, 2020
| ifeq ($(ENABLE_SYNCD_RPC),y) | ||
| $(LIBSAIREDIS)_DEPENDS += $(LIBSAITHRIFT_DEV) | ||
| endif | ||
|
|
There was a problem hiding this comment.
Remove this empty line?
kcudnik
previously approved these changes
Mar 12, 2020
msosyak
dismissed stale reviews from kcudnik, qiluo-msft, and akokhan
via
2803de8
qiluo-msft
approved these changes
Mar 13, 2020
|
retest vsimage please |
|
retest vs please |
|
retest this please |
|
retest default please |
2 similar comments
|
retest default please |
|
retest default please |
|
retest this please |
|
retest vsimage please |
6 similar comments
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
|
retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed compilation with
ENABLE_SYNCD_RPC=yNeed #4253 as well
- How I did it
- How to verify it
Build with
ENABLE_SYNCD_RPC=y- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)