[minigraph.py]: Add support for parsing mux cable #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
* Previous behavior was to set `mux_cable_connection = 'none'` if the port was not connected to a mux cable Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
jleveque
suggested changes
Oct 20, 2020
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
do we need to differentiate U and L for a mux cable port? what is the motivation here? can this be true or false? |
|
@lguohan the minigraph will list the @vdahiya12 for visibility |
|
retest broadcom please |
@lguohan Can the Cli request to change the active TOR to be U or L, if not we can omit this ? |
vdahiya12
previously approved these changes
Oct 23, 2020
jleveque
previously approved these changes
Oct 23, 2020
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
dismissed stale reviews from jleveque and vdahiya12
via
191b817
|
retest vsimage please |
vdahiya12
approved these changes
Oct 26, 2020
lguohan
approved these changes
Oct 26, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
Find LogicalLinks in minigraph and parse the port information. A new field called `mux_cable` is added to each port's entry in the Port table in config DB:
```
PORT|Ethernet0: {
"alias": "Ethernet4/1"
...
"mux_cable": "true"
}
```
If a mux cable is present on a port, the value for `mux_cable` will be `"true"`. If no mux cable is present, the attribute will either be omitted (default behavior) or set to `"false"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
- Why I did it
- How I did it
Find LogicalLinks in minigraph and parse the port information. A new field called
mux_cableis added to each port's entry in the Port table in config DB:If a mux cable is present on a port, the value for
mux_cablewill be"true". If no mux cable is present, the attribute will either be omitted (default behavior) or set to"false".- How to verify it
Run sonic-config-engine tests
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)