Improve the PR build version #7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
force-pushed
the
fix_pr_release_version
branch
from
283cc8b to
cfeae77
Compare
qiluo-msft
approved these changes
Apr 20, 2021
|
i download the image and tested, does not look like the version is correct. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@lguohan , it is depended on the PR #7320, the PR has merged. I re-run it, and test again. |
1 similar comment
@lguohan , it is depended on the PR #7320, the PR has merged. I re-run it, and test again. |
|
"SONIC_IMAGE_VERSION" : "master-7381.0-9c380889" @lguohan , the azure pipelines checks' build looks good now. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
the build id is not matching. |
Yes, I did not export the build number env variable. The reason is that there were some opened PRs changing the same file. So I only change the branch name issue on this PR. |
4 tasks
|
I create a separate PR #7406, but it is ok to merge into this PR(only not sure any conflict). |
lguohan
approved these changes
Apr 23, 2021
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Apr 25, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Apr 25, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
lguohan
pushed a commit
that referenced
this pull request
Apr 25, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
May 10, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
liushilongbuaa
pushed a commit
that referenced
this pull request
May 12, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
liushilongbuaa
pushed a commit
that referenced
this pull request
May 12, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it Improve the version of the Pull Request build by changing the local branch name. How I did it Change the default branch name merge to [target_branch_name]-[pullrequestid]. How to verify it For official build, the version is not changed. For pull request build, the version as below:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Improve the version of the Pull Request build by changing the local branch name.
How I did it
Change the default branch name merge to [target_branch_name]-[pullrequestid].
How to verify it
For official build, the version is not changed.
For pull request build, the version as below:
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)