[neighbour-mac-noptf] Fix issue 2414 by always using static arp/neighbour entry #1026
+36
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 22, 2019 10:38
1. fix the issue which "when" doesn't work when it is in a nested "block" statement 2. don't use the hardcoded "Ethernet0" since in topo t1-lag it belongs a PortChannel and to set ip address on such kind of interface causes orchagent terminated. choice a valiable routed interface for test instead. [show_interface.py] 1. add "vlan" to int_status dict
don't use an ary/neighbour which is a bgp neighbour to do the updating neighbour's mac test, doing in that way can cause bgp connection down and a large number of routing entries withdrawed, failing orchagent to handle neighbour mac update in time. use a newly added address and neighbor on an automatically selected routing interface for that test instead.
…hose oper_state are 'up' and remove startup interface stuffs
1. fix the issue which "when" doesn't work when it is in a nested "block" statement 2. alway use a static arp/neighbour for testing, since the dynamic entries are of the BGP neighbors and to change their mac address causes bgp neighbour down and route withdrew, making system busy and unable to handle mac update in time. we use Ethernet0 for t0 and t1, PortChannel0002 for t1-lag
stepanblyschak
suggested changes
Jul 23, 2019
added 2 commits
July 23, 2019 16:27
This reverts commit 181a522.
dynamically choose an interface from the output of show interface status which meets the following conditions for the test: 1. it is a routing interface 2. it is up. [show_interface] add support for the "vlan" column.
stepanblyschak
approved these changes
Jul 23, 2019
|
@stephanxs, I see that the test now uses 'vlan' interface. But this is not present in t1 topologies. How does it work on t1 topology? |
|
hi Prince, it doesn't choose a vlan interface to do the test. it choose an interface which satisfies both 'up' and 'routed interface' on the dut. |
prsunny
reviewed
Aug 1, 2019
prsunny
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix issue 2414 by always using static arp/neighbour entry for the neighbour-mac-noptf testcase
Type of change
Approach
How did you do it?
we choose an interface meeting 1. routing interface 2. oper_state is up from the output of "show interface status" for the test.
How did you verify/test it?
run the testcase on t0, t1 t1-lag and ptf32
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation