Fix failure case number in test result summary incorrect issue #10485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxin
approved these changes
Oct 26, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
…-net#10485) What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
|
Cherry-pick PR to 202012: #10495 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
…-net#10485) What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
|
Cherry-pick PR to 202205: #10496 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
…-net#10485) What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
|
Cherry-pick PR to 202305: #10497 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
mssonicbld
added
Included in 202012 branch
and removed
Created PR to 202012 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Oct 27, 2023
What is the motivation for this PR? In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way How did you do it? Let failures += failure How did you verify/test it? Run a test with both failure and error, and check the test result xml file
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In test summary, failures += failure + error, but in fact, if a testcase failed with both failure and error, the count of failure and error would both +1, so it's unnecessary to calculate in that way
How did you do it?
Let failures += failure
How did you verify/test it?
Run a test with both failure and error, and check the test result xml file
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation