Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xunit1 as default junit family version #10491

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

xwjiang-ms
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?

Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?

Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxin wangxin merged commit 89e54dd into sonic-net:master Oct 26, 2023
18 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202012: #10492

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #10493

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #10494

@xwjiang-ms xwjiang-ms deleted the use_xunit1_in_pytest branch October 26, 2023 02:42
mssonicbld pushed a commit that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
mssonicbld pushed a commit that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
mssonicbld pushed a commit that referenced this pull request Oct 26, 2023
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file

How did you do it?
Use junit_family=xunit1 by default in pytest.ini file

How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants