-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use xunit1 as default junit family version #10491
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yejianquan
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangxin
approved these changes
Oct 26, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Cherry-pick PR to 202012: #10492 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Cherry-pick PR to 202205: #10493 |
7 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Cherry-pick PR to 202305: #10494 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
mssonicbld
added
Included in 202012 branch
and removed
Created PR to 202012 branch
labels
Oct 26, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
mssonicbld
pushed a commit
that referenced
this pull request
Oct 26, 2023
What is the motivation for this PR? When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file How did you do it? Use junit_family=xunit1 by default in pytest.ini file How did you verify/test it? Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
When we use python3 env to run tests, it would use latest pytest by default, with junit_family=xunit2, which would not generate "file" and "line" field in test result xml file
How did you do it?
Use junit_family=xunit1 by default in pytest.ini file
How did you verify/test it?
Run test in python2 and python3 env, difference is only "file" and "line" fields in xml file
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation