Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[topo_m0] Add new topo for mgmt tor router #6208

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

yaqiangz
Copy link
Contributor

@yaqiangz yaqiangz commented Aug 23, 2022

Description of PR

Summary:
Fixes #5521

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network.

How did you do it?

  • Add a new topo (inherit from t0-52)
  • Enhance topo config and topo_facts for including interfaces
  • Enhance minigraph templates to support generate minigraph for this new topo

How did you verify/test it?

Generate minigraph and deploy to DUT.
Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully,
All the related configuration are correct pushed to DUT after deploy.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Documentation

@Blueve Blueve requested a review from wangxin August 23, 2022 09:21
ansible/library/announce_routes.py Outdated Show resolved Hide resolved
tests/common/testbed.py Outdated Show resolved Hide resolved
ansible/roles/eos/templates/m0-leaf.j2 Show resolved Hide resolved
ansible/vars/topo_m0.yml Show resolved Hide resolved
ansible/vars/topo_m0.yml Outdated Show resolved Hide resolved
ansible/vars/topo_m0.yml Outdated Show resolved Hide resolved
@yaqiangz
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Blueve Blueve merged commit 00b9f3e into sonic-net:master Aug 31, 2022
Blueve pushed a commit that referenced this pull request Sep 5, 2022
What is the motivation for this PR?
Fix cherry pick conflicts of this PR: [topo_m0] Add new topo for mgmt tor router #6208

How did you do it?
Fixed conflicts in:
tests/common/testbed.py
ansible/library/announce_routes.py
ansible/veos
@wangxin
Copy link
Collaborator

wangxin commented Sep 6, 2022

This change is included in 202012 branch by separate PR #6285

Azarack pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 17, 2022
What is the motivation for this PR?
For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network.

How did you do it?
Add a new topo (inherit from t0-52)
Enhance topo config and topo_facts for including interfaces
Enhance minigraph templates to support generate minigraph for this new topo
How did you verify/test it?
Generate minigraph and deploy to DUT.
Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully,
All the related configuration are correct pushed to DUT after deploy.
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this pull request Oct 28, 2022
What is the motivation for this PR?
For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network.

How did you do it?
Add a new topo (inherit from t0-52)
Enhance topo config and topo_facts for including interfaces
Enhance minigraph templates to support generate minigraph for this new topo
How did you verify/test it?
Generate minigraph and deploy to DUT.
Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully,
All the related configuration are correct pushed to DUT after deploy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test Gap] management ToR Routers should be tested with the MgmtToRRouter device type in minigraph
3 participants