-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[topo_m0] Add new topo for mgmt tor router #6208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blueve
suggested changes
Aug 23, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Aug 31, 2022
5 tasks
Blueve
pushed a commit
that referenced
this pull request
Sep 5, 2022
What is the motivation for this PR? Fix cherry pick conflicts of this PR: [topo_m0] Add new topo for mgmt tor router #6208 How did you do it? Fixed conflicts in: tests/common/testbed.py ansible/library/announce_routes.py ansible/veos
This change is included in 202012 branch by separate PR #6285 |
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
What is the motivation for this PR? For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network. How did you do it? Add a new topo (inherit from t0-52) Enhance topo config and topo_facts for including interfaces Enhance minigraph templates to support generate minigraph for this new topo How did you verify/test it? Generate minigraph and deploy to DUT. Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully, All the related configuration are correct pushed to DUT after deploy.
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
What is the motivation for this PR? For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network. How did you do it? Add a new topo (inherit from t0-52) Enhance topo config and topo_facts for including interfaces Enhance minigraph templates to support generate minigraph for this new topo How did you verify/test it? Generate minigraph and deploy to DUT. Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully, All the related configuration are correct pushed to DUT after deploy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #5521
Type of change
Back port request
Approach
What is the motivation for this PR?
For mgmt tor router, both testing methodology and physical wiring pattern are quite different with existing T0/T1/ topo. Adding this topo can let us filter unrelated test cases from mgmt network.
How did you do it?
How did you verify/test it?
Generate minigraph and deploy to DUT.
Use ./testbed-cli.sh deploy-mg to gen&deploy minigraph with new topo m0 successfully,
All the related configuration are correct pushed to DUT after deploy.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
Documentation