Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reboot] Remove INIT_VIEW from event check #7995

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

SavchukRomanLv
Copy link
Contributor

Description of PR

Summary:
Fixes # 14444

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Reboot TC failed with error "Event INIT_VIEW was found 0 times, when expected exactly 1 times"

How did you do it?

Remove INIT_VIEW check

How did you verify/test it?

Run fast/warm reboot. TC passed

Any platform specific information?

SONiC Software Version: SONiC.202211_RC9.2-243f8ce9b

Supported testbed topology if it's a new test case?

Documentation

@SavchukRomanLv SavchukRomanLv requested a review from prgeor as a code owner April 10, 2023 14:53
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The detected issues may be old or new. For new issues, please try to fix them.

For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame
author of this pull request. But if you can take extra effort to fix the old issues as well, that would be great!

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/fixtures/advanced_reboot.py:181:121: E501 line too long (126 > 120 characters)
tests/common/fixtures/advanced_reboot.py:593:121: E501 line too long (123 > 120 characters)
tests/common/fixtures/advanced_reboot.py:715:13: E122 continuation line missing indentation or outdented
tests/common/fixtures/advanced_reboot.py:716:13: E122 continuation line missing indentation or outdented
tests/common/fixtures/advanced_reboot.py:835:1: E302 expected 2 blank lines, found 1

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@SavchukRomanLv
Copy link
Contributor Author

@wangxin can this be merged? thank you !

@wangxin
Copy link
Collaborator

wangxin commented Apr 20, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin merged commit ce35631 into sonic-net:master Apr 24, 2023
@SavchukRomanLv
Copy link
Contributor Author

SavchukRomanLv commented May 16, 2023

@wangxin @yxieca can this be backported to 202205 branch? I put checkbox but I do not see changes in 202205. What are the flow in such case? Thank you!

wangxin pushed a commit that referenced this pull request May 19, 2023
What is the motivation for this PR?
Reboot TC failed with error "Event INIT_VIEW was found 0 times, when expected exactly 1 times"

How did you do it?
Remove INIT_VIEW check

How did you verify/test it?
Run fast/warm reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.202211_RC9.2-243f8ce9b
mrkcmo pushed a commit to Azarack/sonic-mgmt that referenced this pull request Oct 3, 2023
What is the motivation for this PR?
Reboot TC failed with error "Event INIT_VIEW was found 0 times, when expected exactly 1 times"

How did you do it?
Remove INIT_VIEW check

How did you verify/test it?
Run fast/warm reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.202211_RC9.2-243f8ce9b
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
What is the motivation for this PR?
Reboot TC failed with error "Event INIT_VIEW was found 0 times, when expected exactly 1 times"

How did you do it?
Remove INIT_VIEW check

How did you verify/test it?
Run fast/warm reboot. TC passed

Any platform specific information?
SONiC Software Version: SONiC.202211_RC9.2-243f8ce9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants