Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid front panel port handling on recirc port #200

Closed
wants to merge 1 commit into from

Conversation

ysmanman
Copy link

Recirc port is not used as front panel port. So avoid front panel port handling on recirc port.

@arlakshm
Copy link

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Collaborator

prgeor commented Feb 8, 2022

@ysmanman are you still looking for this change? can you fix the conflict?

@ysmanman
Copy link
Author

ysmanman commented Feb 8, 2022

@ysmanman are you still looking for this change? can you fix the conflict?

@prgeor Sure, I will resolve the conflict.

@ysmanman
Copy link
Author

ysmanman commented Feb 9, 2022

@ysmanman are you still looking for this change? can you fix the conflict?

@prgeor Sure, I will resolve the conflict.

@prgeor It seems #251 was already merged. So this PR is not required anymore.

@ysmanman ysmanman closed this Feb 9, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Converted nominal_bit_rate and cable_length fields from the sfp transceiver info dict into str in post_port_sfp_info_to_db.

The documentation for get_transceiver_info in SfpBase indicates that these field values should be integers. However, only string values can be passed into swsscommon.FieldValuePairs. Therefore, a string conversion is needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants