Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asan] suppress the static variable leaks #1085

Merged
merged 2 commits into from
Aug 9, 2022
Merged

[asan] suppress the static variable leaks #1085

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb70011
[asan] suppress the static variable leaks
Yakiv-Huryk Jul 20, 2022
7b50e48
[asan] add missing SWSS_LOG_ENTER()
Yakiv-Huryk Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions syncd/Asan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
#include <csignal>
#include <sanitizer/lsan_interface.h>

extern "C" {
const char* __lsan_default_suppressions() {
return "leak:__static_initialization_and_destruction_0\n";
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds really bad, you are implementing missing import here, why this way ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is rather a callback than a missing import. This is one of the ways to configure ASAN/LSAN.
Another way is to have a file (e.g. supressions.txt) and pass a path to it via env variable options.
The 'callback' approach is simpler and allows to keep all the asan-related things in asan.cpp.
This also seems to be a more popular way to configure the suppressions (e.g. chromium does this).

static void sigterm_handler(int signo)
{
SWSS_LOG_ENTER();
Expand Down