Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all expected environment variables are export before orchagent start #265

Closed
oleksandrivantsiv opened this issue Jul 25, 2017 · 3 comments
Labels

Comments

@oleksandrivantsiv
Copy link
Collaborator

The following lines of code expects environment variable which are not exported:
https://github.com/Azure/sonic-swss/blob/f9d9f181660617d7cf0685af0d6eb6a9ce190972/orchagent/qosorch.cpp#L579
https://github.com/Azure/sonic-swss/blob/d1fdf399e1e0e2e0d71fad1bce2ea7babee2eb48/orchagent/aclorch.cpp#L873

@stcheng
Copy link
Contributor

stcheng commented Jul 25, 2017

Hi Sasha, could you help fix this issue?

@lguohan
Copy link
Contributor

lguohan commented Jul 25, 2017

on which branch? master or 1.0.1?

@stcheng
Copy link
Contributor

stcheng commented Jul 25, 2017

according to this fix: sonic-net/sonic-buildimage#835, it should be both on master and v1.0.1

@stcheng stcheng closed this as completed Oct 9, 2017
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this issue Apr 2, 2023
…erature (sonic-net#265)

* add support for parsing nvme ssd model, health and temperature

Signed-off-by: Kebo Liu <kebol@nvidia.com>

* Add test case for sfp_ssd

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants