Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][everflow] Add retry mechanism for mirror sessions and policers #1961

Open
wants to merge 3 commits into
base: 201911
Choose a base branch
from

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Oct 15, 2021

What I did
This PR is based on #1486. I have to open a PR for branch 201911 since it's not a clean cherry-pick.
This PR is to add retry mechanism for mirror session and policers for below scenarios

  1. Attempting to create ACL rule when mirror session is not created or activated
  2. Attempting to create mirror session when policer is not created.

Some UT issues were also addressed in this PR.

Why I did it
This PR is to add retry mechanism for mirror session and policers for below scenarios.

How I verified it

  1. Verified by UT
test_warm_reboot.py::TestWarmReboot::test_PortSyncdWarmRestart PASSED                                                                                                                                                                                 [ 94%]
test_warm_reboot.py::TestWarmReboot::test_VlanMgrdWarmRestart PASSED                                                                                                                                                                                  [ 94%]
test_warm_reboot.py::TestWarmReboot::test_swss_neighbor_syncup  ^HPASSED                                                                                                                                                                                 [ 95%]
test_warm_reboot.py::TestWarmReboot::test_OrchagentWarmRestartReadyCheck PASSED                                                                                                                                                                       [ 95%]
test_warm_reboot.py::TestWarmReboot::test_swss_port_state_syncup PASSED                                                                                                                                                                               [ 96%]
test_warm_reboot.py::TestWarmReboot::test_routing_WarmRestart  ^H ^H ^HPASSED                                                                                                                                                                                  [ 96%]
test_warm_reboot.py::TestWarmReboot::test_system_warmreboot_neighbor_syncup  ^HPASSED                                                                                                                                                                    [ 97%]
test_warm_reboot.py::TestWarmReboot::test_VrfMgrdWarmRestart PASSED                                                                                                                                                                                   [ 97%]
test_warm_reboot.py::TestWarmReboot::test_MirrorSessionWarmReboot PASSED                                                                                                                                                                              [ 97%]
test_warm_reboot.py::TestWarmReboot::test_EverflowWarmReboot PASSED                                                                                                                                                                                   [ 98%]
test_warm_reboot.py::test_nonflaky_dummy PASSED                                                                                                                                                                                                       [ 98%]
  1. Verified on a testbed by running warm-reboot with warm-reboot assistant. The mirror session and ACL rules were recovered after warm-reboot.

Details if related

bingwang-ms and others added 3 commits October 13, 2021 00:52
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2021

This pull request fixes 1 alert when merging 53748f6 into ce8b1af - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@prsunny
Copy link
Collaborator

prsunny commented Oct 18, 2021

@bingwang-ms , do we need this as a functionality for 201911 or is it a nice-to-have feature? 201911 is currently stable and we probably don't need enhancements but only bug fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants