Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'show vlan config' is not displaying the VLAN members, after the clear config and reload with default l2 configuration. #457

Merged

Conversation

ramachandrareddygaddam
Copy link
Contributor

- What I did
To clear configuration and load default l2 configuration, execute below commands.
redis-cli -n 4 flushdb
redis-cli -n 4 SET CONFIG_DB_INITIALIZED true
sonic-cfggen --preset l2 -H -p -k Accton-AS5712-54X >/etc/sonic/config_db.json
config reload -y

After the clear config with above commands, switch reloaded with l2 default configuration (config_samples.py).
The command 'show vlan brief' displaying the default VLAN (1000) and associated members.
But 'show vlan config' command not displaying not the VLAN information.
To fix this issue, to the default l2 configuration(config_samples.py), all ports are added as members of default VLAN. The VLAN dict is updated with members list.

- How I did it
In config_samples.py file, members are added to default Vlan(1000).
In sonic-utilities/show/main.py the VLAN information displayed correctly.

- How to verify it
Do clear config and reload switch with default l2 configuration.
check the VLAN information displayed correctly.

- Previous command output (if the output of a command-line utility has changed)
root@sonic:~# show vlan config
Name VID Member Mode


root@sonic:~#

- New command output (if the output of a command-line utility has changed)
root@sonic:~# show vlan config
Name VID Member Mode


Vlan1000 1000 Ethernet0 untagged
Vlan1000 1000 Ethernet1 untagged
Vlan1000 1000 Ethernet2 untagged
Vlan1000 1000 Ethernet3 untagged
Vlan1000 1000 Ethernet4 untagged
Vlan1000 1000 Ethernet5 untagged
.....
Vlan1000 1000 Ethernet67 untagged
Vlan1000 1000 Ethernet68 untagged
Vlan1000 1000 Ethernet69 untagged
Vlan1000 1000 Ethernet70 untagged
Vlan1000 1000 Ethernet71 untagged
root@sonic:~#

…onfig and reload with default l2 configuration.
@jleveque
Copy link
Contributor

Retest this please

@ramachandrareddygaddam
Copy link
Contributor Author

ramachandrareddygaddam commented Feb 27, 2019

sonic-net/sonic-buildimage#2536 fix - for default L2 configuration is adding VLAN members to VLAN 1000.
But from CLI, When we add vlan without members, 'show vlan config' is not displaying the VLAN information. This fix will resolve the issue and display VLAN information.

@ramachandrareddygaddam
Copy link
Contributor Author

'show vlan config' is not displaying VLAN information, when no members present in the VLAN. This fix will resolve the issue. Request to merge the fix.

@jleveque jleveque merged commit 7657001 into sonic-net:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants