Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatting: include title in assignee, label, & milestone webhooks #79

Merged
merged 1 commit into from
Nov 2, 2020
Merged

formatting: include title in assignee, label, & milestone webhooks #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions sopel_modules/github/formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,18 @@ def get_issue_or_pr_number(payload=None):
return number


def get_issue_or_pr_title(payload=None):
if not payload:
payload = current_payload

try:
title = payload['issue']['title']
except KeyError:
title = payload['pull_request']['title']

return title


def fmt_push_summary_message(payload=None, row=None):
if not payload:
payload = current_payload
Expand Down Expand Up @@ -316,27 +328,29 @@ def fmt_issue_assignee_message(payload=None):
else:
target = 'to ' if payload['action'] == 'assigned' else 'from '
target = target + fmt_name(payload['assignee']['login'])
return '[{}] {} {}{} {} #{} {}'.format(
return '[{}] {} {}{} {} #{} {} ({})'.format(
fmt_repo(payload['repository']['name']),
fmt_name(payload['sender']['login']),
'self-' if self_assign else '',
payload['action'],
get_issue_type(payload),
get_issue_or_pr_number(payload),
target)
target,
get_issue_or_pr_title(payload))


def fmt_issue_label_message(payload=None):
if not payload:
payload = current_payload
return '[{}] {} {} the label \'{}\' {} {} #{}'.format(
return '[{}] {} {} the label \'{}\' {} {} #{} ({})'.format(
fmt_repo(payload['repository']['name']),
fmt_name(payload['sender']['login']),
'added' if payload['action'] == 'labeled' else 'removed',
payload['label']['name'],
'to' if payload['action'] == 'labeled' else 'from',
get_issue_type(payload),
get_issue_or_pr_number(payload))
get_issue_or_pr_number(payload),
get_issue_or_pr_title(payload))


def fmt_issue_milestone_message(payload=None):
Expand All @@ -345,12 +359,13 @@ def fmt_issue_milestone_message(payload=None):

added = payload['action'] == 'milestoned'

return '[{}] {} {} {} #{} {} the {} milestone'.format(
return '[{}] {} {} {} #{} ({}) {} the {} milestone'.format(
fmt_repo(payload['repository']['name']),
fmt_name(payload['sender']['login']),
'added' if added else 'removed',
get_issue_type(payload),
get_issue_or_pr_number(payload),
get_issue_or_pr_title(payload),
'to' if added else 'from',
payload['milestone']['title'])

Expand Down