Configuration of Flood Protection

[deathbybandaid]

I think the Flood Protection should be configurable from the config file.

I have my bot behind ZNC for multiple reasons, and prefer the adjustability of it's flood protection, so the bot doesn't get kicked.

I think adding this to the core.config would be beneficial.

[dgw]

Not super high on the priority list right now, but a PR adding this would get a look.

[deathbybandaid]

Do you think any of this is still relevant/usable?

f58fa9f

[dgw]

As far as I can see from #908, that was probably left unmerged because Embolalia pushed back on having config settings, and then @larsks closed it when the conversation stalled.

If you want to use that commit as a starting point (presumably you've read through #908 already?), I can't think of a reason not to. I would just ask that you rebase f58fa9f onto current master to keep credit for that code around in the commit log (and fix the typos in the commit message while you're at it, seeing as @larsks fixed them in the top PR comment anyway).

Out of courtesy, I also pinged @larsks. I think it's nice to ask people before building on unfinished code.

[dgw]

This seems like a good feature to add in the next major version, so I've assigned it to the 7.0.0 milestone.

@deathbybandaid With no answer from @larsks in the last 5 months, I think it's safe for you to have at this if you're still interested in working on it.

[predakanga]

This feature is one of the last remaining roadblocks in un-forking our own copy of Sopel, so I thought I'd offer the patch myself.

[Exirel]

so I thought I'd offer the patch myself.

Oh, that's lovely, thank you! ❤️ In one way or another, I hope Sopel 7 will be able to replace your fork, so you don't have to maintain it—I know how much time it can require!

[Exirel]

As I see it, #1518 fixed that (and the documentation is on its way).