Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd support #262

Closed
4 tasks done
elad661 opened this issue May 20, 2013 · 8 comments
Closed
4 tasks done

systemd support #262

elad661 opened this issue May 20, 2013 · 8 comments
Labels
Feature Low Priority Tracking
Milestone
7.0.0

Comments

@elad661
Copy link
Contributor

elad661 commented May 20, 2013 •
edited by dgw
Loading

@ghost ghost assigned elad661 May 20, 2013
elad661 pushed a commit that referenced this issue May 24, 2013
[core] Add systemd service file and other default config files for di…
5c9991a 
…stros

See contrib/README for more information.
Also modified willie.py to support a new config key in [core]:
not_configured will cause the bot to refuse running if set to true.
This is useful to force users to configure the bot before trying to run it as the config wizard is not ideal for willie running as a service.

Issue #262
@elad661
Copy link
Contributor Author

elad661 commented Feb 16, 2014

I decided multiple-instance usecase is too rare to support it with systemd. As for journal, there's no real need either at the moment (as willie doesn't do anything that can use systemd-journal's various metadata features in a way that makes sense)

@elad661 elad661 closed this as completed Feb 16, 2014
@elad661 elad661 removed their assignment Jul 25, 2015
@anarcat
Copy link

anarcat commented Aug 30, 2016

relevant: #1059

@dgw dgw added the Tracking label Mar 26, 2018
@dgw dgw added this to the 7.0.0 milestone Mar 26, 2018
@dgw
Copy link
Member

dgw commented Mar 26, 2018

Reopening to look at completing this task list in 7.0.0.

@dgw dgw reopened this Mar 26, 2018
@Exirel
Copy link
Contributor

Exirel commented Jan 12, 2019

I think most of the work has been done, at least from what I know of systemd on Ubuntu.

However, the user-experience is not really optimal, as you have to configure yourself the file, or know the exact location of the config file, etc.

More documentation, or better tooling could be interesting in this case.

@dgw
Copy link
Member

dgw commented Mar 22, 2019

According to the systemd-journald service documentation:

The systemd service manager invokes all service processes with standard output and standard error connected to the journal by default. This behaviour may be altered via the StandardOutput=/StandardError= unit file settings, see systemd.exec(5) for details. The journal converts the log byte stream received this way into individual log records, splitting the stream at newline ("\n", ASCII 10) and NUL bytes.

Our last remaining checkbox (supporting systemd Journal integration for logging) might already be done, then, and we can maybe close this issue. Our example systemd unit files don't override that default.

I'm running Sopel in production on an old Upstart system, personally, so someone else should check my research. @ddstreet, you just opened a systemd-related PR earlier today. Would you mind weighing in?

@dgw dgw mentioned this issue Jul 5, 2019
Closed
@dgw dgw removed this from the 7.0.0 milestone Nov 16, 2019
@dgw
Copy link
Member

dgw commented Nov 16, 2019

I'd argue that journal support is pretty irrelevant now with the improvements to Sopel's own logging (see #1678). Let's just close this one.

@dgw dgw closed this as completed Nov 16, 2019
@Exirel
Copy link
Contributor

Exirel commented Nov 16, 2019

I think it's actually "done".

@dgw dgw added this to the 7.0.0 milestone Nov 16, 2019
@ddstreet
Copy link

ddstreet commented Dec 3, 2019

I'm running Sopel in production on an old Upstart system, personally, so someone else should check my research. @ddstreet, you just opened a systemd-related PR earlier today. Would you mind weighing in?

really sorry, for some reason I just got an email for this with the last comment, and I missed your comment from March.

in any case, seems like this is all done, but sorry for missing your earlier request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Low Priority Tracking
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@dgw @elad661 @ddstreet @anarcat @Exirel