search: remove tests that hit Bing #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bing returning inconsistent results has been the number-one cause of CI failures for the last several months. Basically the only cause, in fact. Kicking the CI occasionally to re-run a failed job was tolerable, but it's reached a point where seemingly no number of job restarts will get a successful test run out of Bing, so away the tests will go. Coveralls will probably yell at me for merging this, but I don't care. I'm tired of seeing red X's on pull requests because of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bing returning inconsistent results has been the number-one cause of CI failures for the last several months. Basically the only cause, in fact.
Kicking the CI occasionally to re-run a failed job was tolerable, but it's reached a point where seemingly no number of job restarts will get a successful test run out of Bing, so away the tests will go.
Coveralls will probably yell at me because this reduces coverage, but I don't care. I'm tired of seeing red X's on pull requests because of this. (Edit: "Coverage increased (+0.2%) to 42.833%"? What?)