Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Bing regex needs to be less specific #1854

Merged
merged 1 commit into from
May 1, 2020
Merged

search: Bing regex needs to be less specific #1854

merged 1 commit into from
May 1, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented May 1, 2020

Description

The OL element isn't always in the same place. Sometimes there are other things between it and the first LI.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

The OL element isn't always in the same place. Sometimes there are other
things between it and the first LI.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label May 1, 2020
@dgw dgw added this to the 7.0.3 milestone May 1, 2020
@dgw dgw requested a review from a team May 1, 2020 06:26
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on bing, so I hope it works. If you say it does, I believe you.

In the long run, there is no way to know if this will work forever. We have to accept that it might fail sometimes, or at some point in the future. Let's not worry too much bout that. People can still use a regular search engine on their regular browser of choice.

@dgw
Copy link
Member Author

dgw commented May 1, 2020

In the long run, there is no way to know if this will work forever. We have to accept that it might fail sometimes, or at some point in the future.

Indeed, it's hard to test this reliably without some layer to insulate our tests from the frequent errors/blocks Bing sends back when hit from a datacenter IP. (I'm speculating this is why our Bing tests are so flaky, but I can't ever trigger the flakiness from home.)

You know I'm thinking about how to make such a layer as in #1853 work while still catching actual upstream changes, and I hope you'll participate in that—on a day when you have more motivation, maybe. 😸

@dgw dgw merged commit 5877bcd into master May 1, 2020
@dgw dgw deleted the fix-bing-again branch May 1, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants