Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reddit: use new find rule type to get all slash-refs in line #1892

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 16, 2020

Description

We're no longer restricted to matching only one u/ or r/ reference per line thanks to #1881.

Closes no issue, because I knew I'd remember without one. 😝

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Tweak label Jun 16, 2020
@dgw dgw added this to the 7.1.0 milestone Jun 16, 2020
@dgw dgw requested a review from a team June 16, 2020 20:44
sopel/modules/reddit.py Outdated Show resolved Hide resolved
@dgw dgw requested a review from Exirel June 17, 2020 06:33
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing my work being used right away like that! ❤️

@dgw dgw merged commit 9c87a35 into master Jun 19, 2020
@dgw dgw deleted the reddit-multi-slashinfo branch June 19, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants