Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc, config: config options for flood penalty on longer messages #1929

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Aug 25, 2020

Description

It was asked by someone on IRC so I added some config options to control extra wait penalty on longer messages, and one thing led to another I also added a setting to control the maximum wait time because why not.

I've to say that @dgw was right again, but maybe even more "on the nose" than ever before:

07:22:51 <+dgw> It's some arcane magic from AT LEAST a decade ago.
         https://github.com/sopel-irc/sopel/blame/d610029b3933c2ddd6751a7523dd12a30cf4ae8b/irc.py#L139
07:23:24 <+dgw> actually 11
         https://github.com/sopel-irc/sopel/blame/c79635a1627813028d48b2cd0a5e226cd116bae5/irc.py#L135
07:23:28 <+dgw> "Initial commit"
07:23:33 <+dgw> can't get older than that
[...]
07:25:19 <+dgw> also, like half the code in Sopel makes me go hmm

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Feature label Aug 25, 2020
@Exirel Exirel added this to the 7.1.0 milestone Aug 25, 2020
@dgw dgw self-requested a review August 25, 2020 16:17
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have a first pass. I probably missed some things, but caught most issues that actually matter. 😹

docs/source/configuration.rst Outdated Show resolved Hide resolved
docs/source/configuration.rst Outdated Show resolved Hide resolved
docs/source/configuration.rst Outdated Show resolved Hide resolved
docs/source/configuration.rst Outdated Show resolved Hide resolved
docs/source/configuration.rst Outdated Show resolved Hide resolved
sopel/config/core_section.py Outdated Show resolved Hide resolved
sopel/config/core_section.py Outdated Show resolved Hide resolved
sopel/irc/__init__.py Show resolved Hide resolved
sopel/irc/__init__.py Outdated Show resolved Hide resolved
sopel/irc/__init__.py Outdated Show resolved Hide resolved
@Exirel
Copy link
Contributor Author

Exirel commented Aug 27, 2020

@dgw I applied your changes and improved the debug log. Ready for re-review at your convenience.

@Exirel Exirel requested a review from dgw August 27, 2020 17:14
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's 🚢 it

@Exirel
Copy link
Contributor Author

Exirel commented Aug 27, 2020

🐑 🐑 🐑 🐑

@dgw dgw merged commit f7bf3da into sopel-irc:master Sep 12, 2020
@Exirel Exirel deleted the flood-penalty-long-message branch May 1, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants