Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix invalid usage of r-string for SASL auth token #1976

Merged
merged 1 commit into from
Oct 31, 2020
Merged

core: fix invalid usage of r-string for SASL auth token #1976

merged 1 commit into from
Oct 31, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Oct 31, 2020

Description

Fix #1974

@dgw if this can be merged in priority, as this bug prevent from using SASL in dev (I don't use SASL so I didn't notice).

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added High Priority Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Oct 31, 2020
@Exirel Exirel added this to the 7.1.0 milestone Oct 31, 2020
@Exirel Exirel requested a review from dgw October 31, 2020 14:27
@Exirel Exirel mentioned this pull request Oct 31, 2020
Closed
dgw
dgw requested changes Oct 31, 2020
View reviewed changes
sopel/coretasks.py Outdated Show resolved Hide resolved
dgw
dgw approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI ran really fast on this… We should do all our stuff on the weekends! 🤣

@Exirel @dgw
core: fix invalid usage of raw string for SASL auth token
fcd8365 
Also use `\x00` instead of `\0`, which is an invalid escape sequence as
of Python 3.8: https://docs.python.org/3.8/library/re.html (no relevant
anchor; search for "invalid escape" in page contents).

Co-authored-by: dgw <dgw@technobabbl.es>
@dgw dgw merged commit 846b126 into sopel-irc:master Oct 31, 2020
@dgw dgw mentioned this pull request Oct 31, 2020
Merged
4 tasks
@Exirel Exirel deleted the core-fix-sasl-auth-token branch May 1, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) High Priority
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Invalid format of AUTHENTICATE message
2 participants
@Exirel @dgw