Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, modules: replace deprecated uses of parse=bool in settings #2059

Merged
merged 7 commits into from
May 7, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented May 4, 2021

Description

This just eliminates a bunch of deprecation warnings that we probably don't want to ship in 7.1.0.

These should have been fixed as part of #2044, but past-me was apparently quite lazy. 🙃
However they were also the inspiration for, and an easy way to test, #2058. 🙂

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added this to the 7.1.0 milestone May 4, 2021
@dgw dgw requested a review from a team May 4, 2021 05:22
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review here, so it's pretty easy to approve!

@dgw
Copy link
Member Author

dgw commented May 7, 2021

Will merge pending official review of #2058. The last master revision to contain these deprecation warnings in core was a6ff24e, which can still be used via "detached HEAD" checkout to test this without artificially inserting deprecated usage.

@dgw dgw merged commit 308f142 into master May 7, 2021
@dgw dgw deleted the deprecated-bool-settings branch May 7, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants