Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable s3 chunked uploads #466

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Oct 21, 2021

Some S3 like services don't support s3 signed chunked uploads. See soto-project/soto#542

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #466 (438e52a) into main (1f5878c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
+ Coverage   75.69%   75.75%   +0.05%     
==========================================
  Files          67       67              
  Lines        5426     5427       +1     
==========================================
+ Hits         4107     4111       +4     
+ Misses       1319     1316       -3     
Impacted Files Coverage Δ
Sources/SotoCore/AWSServiceConfig.swift 97.56% <ø> (ø)
Sources/SotoCore/AWSClient.swift 89.36% <100.00%> (ø)
Sources/SotoCore/Message/AWSRequest.swift 92.38% <100.00%> (+1.42%) ⬆️
Sources/SotoTestUtils/TestUtils.swift 86.79% <100.00%> (+0.25%) ⬆️
...toCore/Credential/CredentialProviderSelector.swift 93.33% <0.00%> (-6.67%) ⬇️
Sources/SotoSignerV4/signer.swift 91.48% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5878c...438e52a. Read the comment docs.

@adam-fowler adam-fowler merged commit 41f4beb into main Oct 22, 2021
@adam-fowler adam-fowler deleted the disable-s3-chunked-uploads branch October 22, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants