From ee34406aa7c2d08cadd98733c1e7aca1e1b8b243 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sat, 15 Oct 2022 23:25:48 +0200 Subject: [PATCH 01/15] Add code-quality qodana workflow --- .github/workflows/code-quality.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/workflows/code-quality.yml diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml new file mode 100644 index 00000000..55beae22 --- /dev/null +++ b/.github/workflows/code-quality.yml @@ -0,0 +1,18 @@ +name: Qodana +on: + workflow_dispatch: + pull_request: + push: + branches: + - main + - dev-* + +jobs: + qodana: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + with: + fetch-depth: 0 + - name: 'Qodana Scan' + uses: JetBrains/qodana-action@v2022.2.2 From 096e688d6554378714e885884b8511d353ca45d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 00:03:19 +0200 Subject: [PATCH 02/15] Fix branch name --- .github/workflows/code-quality.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index 55beae22..f0b2a8cb 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -4,9 +4,8 @@ on: pull_request: push: branches: - - main + - master - dev-* - jobs: qodana: runs-on: ubuntu-latest From 29fe3d5848278dd3078c14f7ad36baab623cd4e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 00:03:57 +0200 Subject: [PATCH 03/15] Add qodana.yml --- .github/qodana.yml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .github/qodana.yml diff --git a/.github/qodana.yml b/.github/qodana.yml new file mode 100644 index 00000000..f5b6ad3d --- /dev/null +++ b/.github/qodana.yml @@ -0,0 +1,3 @@ +version: 1.0 +profile: + name: qodana.recommended From 405ee039464faf3b61b77f30e48594f2f1a1ea62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 00:08:19 +0200 Subject: [PATCH 04/15] Move qodana.yml to root --- .github/qodana.yml => qodana.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/qodana.yml => qodana.yml (100%) diff --git a/.github/qodana.yml b/qodana.yml similarity index 100% rename from .github/qodana.yml rename to qodana.yml From 34ecd5bbc1b452569d6aa45abb707365d3371ab2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 00:15:13 +0200 Subject: [PATCH 05/15] aaa --- qodana.yml => qodana.yaml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename qodana.yml => qodana.yaml (100%) diff --git a/qodana.yml b/qodana.yaml similarity index 100% rename from qodana.yml rename to qodana.yaml From 1533181ca70aeb9ecb5b98fa16e25cb8da873b6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 00:21:30 +0200 Subject: [PATCH 06/15] Try this --- qodana.yaml | 3 --- qodana.yml | 29 +++++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-) delete mode 100644 qodana.yaml create mode 100644 qodana.yml diff --git a/qodana.yaml b/qodana.yaml deleted file mode 100644 index f5b6ad3d..00000000 --- a/qodana.yaml +++ /dev/null @@ -1,3 +0,0 @@ -version: 1.0 -profile: - name: qodana.recommended diff --git a/qodana.yml b/qodana.yml new file mode 100644 index 00000000..7a5a3fad --- /dev/null +++ b/qodana.yml @@ -0,0 +1,29 @@ +version: 1.0 +profile: + name: qodana.recommended +include: + - name: Anonymous2MethodRef + - name: AssignmentToCatchBlockParameter + - name: AssignmentToLambdaParameter + - name: AssignmentToMethodParameter + - name: AssignmentToNull + - name: Convert2Lambda + - name: DoubleBraceInitialization + - name: EqualsAndHashcode + - name: JavaLangImport + - name: MissortedModifiers + - name: NestedAssignment + - name: NonShortCircuitBoolean + - name: RedundantFieldInitialization + - name: RedundantSuppression + - name: Reformat + - name: ReturnNull + - name: SamePackageImport + - name: StringEquality + - name: UnnecessaryBoxing + - name: UnnecessaryLocalVariable + - name: UnnecessaryUnboxing + - name: UNUSED_IMPORT + - name: PointlessBooleanExpression +exclude: + - name: UseOfClone From 5a36c3aede7e766d68fec6beb66bbacb299b6ea3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Sun, 16 Oct 2022 10:03:30 +0200 Subject: [PATCH 07/15] Go back to qodana.yaml --- qodana.yaml | 3 +++ qodana.yml | 29 ----------------------------- 2 files changed, 3 insertions(+), 29 deletions(-) create mode 100644 qodana.yaml delete mode 100644 qodana.yml diff --git a/qodana.yaml b/qodana.yaml new file mode 100644 index 00000000..f5b6ad3d --- /dev/null +++ b/qodana.yaml @@ -0,0 +1,3 @@ +version: 1.0 +profile: + name: qodana.recommended diff --git a/qodana.yml b/qodana.yml deleted file mode 100644 index 7a5a3fad..00000000 --- a/qodana.yml +++ /dev/null @@ -1,29 +0,0 @@ -version: 1.0 -profile: - name: qodana.recommended -include: - - name: Anonymous2MethodRef - - name: AssignmentToCatchBlockParameter - - name: AssignmentToLambdaParameter - - name: AssignmentToMethodParameter - - name: AssignmentToNull - - name: Convert2Lambda - - name: DoubleBraceInitialization - - name: EqualsAndHashcode - - name: JavaLangImport - - name: MissortedModifiers - - name: NestedAssignment - - name: NonShortCircuitBoolean - - name: RedundantFieldInitialization - - name: RedundantSuppression - - name: Reformat - - name: ReturnNull - - name: SamePackageImport - - name: StringEquality - - name: UnnecessaryBoxing - - name: UnnecessaryLocalVariable - - name: UnnecessaryUnboxing - - name: UNUSED_IMPORT - - name: PointlessBooleanExpression -exclude: - - name: UseOfClone From 7b0f228b1bf85c244ff0c9fbebf1fdf5d0e4d0e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Mon, 17 Oct 2022 19:33:24 +0200 Subject: [PATCH 08/15] Add jvm community linter --- qodana.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/qodana.yaml b/qodana.yaml index f5b6ad3d..04972816 100644 --- a/qodana.yaml +++ b/qodana.yaml @@ -1,3 +1,4 @@ version: 1.0 +linter: jetbrains/qodana-jvm-community:2022.2 profile: name: qodana.recommended From f5dd59c1654ff2d3832d4284cbb93972bfba7662 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Mon, 17 Oct 2022 19:40:26 +0200 Subject: [PATCH 09/15] Try IJ ultimate linter --- qodana.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qodana.yaml b/qodana.yaml index 04972816..32cb7a5c 100644 --- a/qodana.yaml +++ b/qodana.yaml @@ -1,4 +1,4 @@ version: 1.0 -linter: jetbrains/qodana-jvm-community:2022.2 +linter: jetbrains/qodana-jvm:2022.2-eap profile: name: qodana.recommended From e57be7db52993f556c95096633c43eeab996f925 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Mon, 17 Oct 2022 20:01:19 +0200 Subject: [PATCH 10/15] Try with .yml --- qodana.yaml => qodana.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename qodana.yaml => qodana.yml (100%) diff --git a/qodana.yaml b/qodana.yml similarity index 100% rename from qodana.yaml rename to qodana.yml From 9adabc11c088b237fa029243fa27646a4a34cec9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Mon, 17 Oct 2022 20:07:40 +0200 Subject: [PATCH 11/15] Move qodana.yml to .github --- qodana.yml => .github/qodana.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename qodana.yml => .github/qodana.yml (100%) diff --git a/qodana.yml b/.github/qodana.yml similarity index 100% rename from qodana.yml rename to .github/qodana.yml From 8bc6b9139fd0c1cdeaf005188ad19a84ca0cabb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Mon, 17 Oct 2022 20:18:35 +0200 Subject: [PATCH 12/15] Move qodana.yml to root and add checks --- .github/qodana.yml | 4 ---- qodana.yml | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 4 deletions(-) delete mode 100644 .github/qodana.yml create mode 100644 qodana.yml diff --git a/.github/qodana.yml b/.github/qodana.yml deleted file mode 100644 index 32cb7a5c..00000000 --- a/.github/qodana.yml +++ /dev/null @@ -1,4 +0,0 @@ -version: 1.0 -linter: jetbrains/qodana-jvm:2022.2-eap -profile: - name: qodana.recommended diff --git a/qodana.yml b/qodana.yml new file mode 100644 index 00000000..957b827e --- /dev/null +++ b/qodana.yml @@ -0,0 +1,28 @@ +version: 1.0 +linter: jetbrains/qodana-jvm:2022.2-eap +profile: + name: qodana.recommended +include: + - name: Anonymous2MethodRef + - name: AssignmentToCatchBlockParameter + - name: AssignmentToLambdaParameter + - name: AssignmentToMethodParameter + - name: AssignmentToNull + - name: Convert2Lambda + - name: DoubleBraceInitialization + - name: EqualsAndHashcode + - name: JavaLangImport + - name: MissortedModifiers + - name: NestedAssignment + - name: NonShortCircuitBoolean + - name: RedundantFieldInitialization + - name: RedundantSuppression + - name: Reformat + - name: ReturnNull + - name: SamePackageImport + - name: StringEquality + - name: UnnecessaryBoxing + - name: UnnecessaryLocalVariable + - name: UnnecessaryUnboxing + - name: UNUSED_IMPORT + - name: PointlessBooleanExpression From cb88b8c924bd75a0ca64a3353c5bbd079acc6f3c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Tue, 12 Sep 2023 08:30:59 +0200 Subject: [PATCH 13/15] Update action versions --- .github/workflows/code-quality.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/code-quality.yml b/.github/workflows/code-quality.yml index f0b2a8cb..5bd209df 100644 --- a/.github/workflows/code-quality.yml +++ b/.github/workflows/code-quality.yml @@ -10,8 +10,8 @@ jobs: qodana: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: 'Qodana Scan' - uses: JetBrains/qodana-action@v2022.2.2 + uses: JetBrains/qodana-action@v2023.2.6 From 5d1a0e2f760183d732697d688787b7c7fcca1415 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Tue, 12 Sep 2023 08:33:14 +0200 Subject: [PATCH 14/15] Update linter version --- qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qodana.yml b/qodana.yml index 957b827e..ffb34497 100644 --- a/qodana.yml +++ b/qodana.yml @@ -1,5 +1,5 @@ version: 1.0 -linter: jetbrains/qodana-jvm:2022.2-eap +linter: jetbrains/qodana-jvm:2023.2.5 profile: name: qodana.recommended include: From a75adb6de50419e178a9480193a0d7aad2e41d01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20St=C3=A4ding?= Date: Tue, 12 Sep 2023 08:35:13 +0200 Subject: [PATCH 15/15] Fix linter version --- qodana.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qodana.yml b/qodana.yml index ffb34497..54921dee 100644 --- a/qodana.yml +++ b/qodana.yml @@ -1,5 +1,5 @@ version: 1.0 -linter: jetbrains/qodana-jvm:2023.2.5 +linter: jetbrains/qodana-jvm:2023.2 profile: name: qodana.recommended include: