Update ST3 branch with Sourcegraph-specific changes

[varungandhi-src]

As part of updating the Packages dependency in sourcegraph/syntect#9, I was investigating what it would take to land Sourcegraph-specific changes on the st3 branch (i.e. option 1 in that issue).

However, there are baseline test failures on that branch. 😬 https://github.com/sourcegraph/Packages/actions/runs/1703979906

Here are the failures:

Running: /Data/Packages/ASP/syntax_test_asp.asp
/Data/Packages/ASP/syntax_test_asp.asp:594:14: [entity.name.function.asp] does not match scope [text.html.asp source.asp.embedded.html meta.method.asp meta.method.identifier.asp invalid.illegal.expected-end-of-line.asp]
/Data/Packages/ASP/syntax_test_asp.asp:594:15: [entity.name.function.asp] does not match scope [text.html.asp source.asp.embedded.html meta.method.asp meta.method.identifier.asp invalid.illegal.expected-end-of-line.asp]
/Data/Packages/ASP/syntax_test_asp.asp:594:16: [entity.name.function.asp] does not match scope [text.html.asp source.asp.embedded.html meta.method.asp meta.method.identifier.asp invalid.illegal.expected-end-of-line.asp]

Running: /Data/Packages/PHP/syntax_test_php.php
/Data/Packages/PHP/syntax_test_php.php:1307:4: Unknown symbol specifier 'see https://wiki.php.net/rfc/flexible_heredoc_nowdoc_syntaxes'
/Data/Packages/PHP/syntax_test_php.php:693:10: Unexpected symbol found ['method' reference]
/Data/Packages/PHP/syntax_test_php.php:225:10: Unexpected symbol found ['foo' definition]
/Data/Packages/PHP/syntax_test_php.php:1364:6: Unexpected symbol found ['CSS: punctuation.section.property-list ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:693:17: Unexpected symbol found ['func_call' reference]
/Data/Packages/PHP/syntax_test_php.php:1280:1: Unexpected symbol found ['preg_replace' reference]
/Data/Packages/PHP/syntax_test_php.php:1364:18: Unexpected symbol found ['section.property-list' global-definition]
/Data/Packages/PHP/syntax_test_php.php:707:1: Unexpected symbol found ['strval' reference]
/Data/Packages/PHP/syntax_test_php.php:185:12: Unexpected symbol found ['array_map' reference]
/Data/Packages/PHP/syntax_test_php.php:965:16: Unexpected symbol found ['undo' reference]
/Data/Packages/PHP/syntax_test_php.php:164:10: Unexpected symbol found ['b' definition]
/Data/Packages/PHP/syntax_test_php.php:1110:11: Unexpected symbol found ['ArRaY_RaNd' reference]
/Data/Packages/PHP/syntax_test_php.php:1359:13: Unexpected symbol found ['CSS: punctuation.section.embedded.begin punctuation.definition.string ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1488:109: Unexpected symbol found ['ID: myid' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1549:21: Unexpected symbol found ['__toStringTest' definition]
/Data/Packages/PHP/syntax_test_php.php:1556:21: Unexpected symbol found ['__test' definition]
/Data/Packages/PHP/syntax_test_php.php:1293:1: Unexpected symbol found ['preg_replace' reference]
/Data/Packages/PHP/syntax_test_php.php:987:10: Unexpected symbol found ['inverse' reference]
/Data/Packages/PHP/syntax_test_php.php:1359:25: Unexpected symbol found ['section.embedded.begin' global-definition]
/Data/Packages/PHP/syntax_test_php.php:606:11: Unexpected symbol found ['MyInter' definition]
/Data/Packages/PHP/syntax_test_php.php:1542:21: Unexpected symbol found ['__toString' definition]
/Data/Packages/PHP/syntax_test_php.php:3:11: Unexpected symbol found ['MyNamespace' definition]
/Data/Packages/PHP/syntax_test_php.php:1365:26: Unexpected symbol found ['CSS: string.quoted.single h3 ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:701:20: Unexpected symbol found ['method' reference]
/Data/Packages/PHP/syntax_test_php.php:174:10: Unexpected symbol found ['f' definition]
/Data/Packages/PHP/syntax_test_php.php:1045:10: Unexpected symbol found ['generate' definition]
/Data/Packages/PHP/syntax_test_php.php:1463:18: Unexpected symbol found ['foo' definition]
/Data/Packages/PHP/syntax_test_php.php:725:45: Unexpected symbol found ['Test1' reference]
/Data/Packages/PHP/syntax_test_php.php:1365:33: Unexpected symbol found ['quoted.single' global-definition]
/Data/Packages/PHP/syntax_test_php.php:725:62: Unexpected symbol found ['Countable' reference]
/Data/Packages/PHP/syntax_test_php.php:1245:1: Unexpected symbol found ['preg_replace' reference]
/Data/Packages/PHP/syntax_test_php.php:259:7: Unexpected symbol found ['meth' reference]
/Data/Packages/PHP/syntax_test_php.php:165:10: Unexpected symbol found ['c' definition]
/Data/Packages/PHP/syntax_test_php.php:1359:60: Unexpected symbol found ['definition.string' global-definition]
/Data/Packages/PHP/syntax_test_php.php:938:21: Unexpected symbol found ['abc' definition]
/Data/Packages/PHP/syntax_test_php.php:116:47: Unexpected symbol found ['fn_g' definition]
/Data/Packages/PHP/syntax_test_php.php:1661:1: Unexpected symbol found ['CSS: h1 ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:884:7: Unexpected symbol found ['A' definition]
/Data/Packages/PHP/syntax_test_php.php:1535:21: Unexpected symbol found ['__debugInfo' definition]
/Data/Packages/PHP/syntax_test_php.php:175:10: Unexpected symbol found ['i' definition]
/Data/Packages/PHP/syntax_test_php.php:1024:36: Unexpected symbol found ['getMessage' reference]
/Data/Packages/PHP/syntax_test_php.php:1360:13: Unexpected symbol found ['CSS: keyword.operator.heredoc h2 ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1176:22: Unexpected symbol found ['version' local-definition]
/Data/Packages/PHP/syntax_test_php.php:743:14: Unexpected symbol found ['noReturnType' definition]
/Data/Packages/PHP/syntax_test_php.php:1051:10: Unexpected symbol found ['generate2' definition]
/Data/Packages/PHP/syntax_test_php.php:1360:21: Unexpected symbol found ['operator.heredoc' global-definition]
/Data/Packages/PHP/syntax_test_php.php:610:11: Unexpected symbol found ['MyInter2' definition]
/Data/Packages/PHP/syntax_test_php.php:1367:26: Unexpected symbol found ['CSS: variable.other.php ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1367:35: Unexpected symbol found ['other.php' global-definition]
/Data/Packages/PHP/syntax_test_php.php:171:10: Unexpected symbol found ['e' definition]
/Data/Packages/PHP/syntax_test_php.php:610:28: Unexpected symbol found ['\MyNamespace\Foo' reference]
/Data/Packages/PHP/syntax_test_php.php:1053:16: Unexpected symbol found ['generate' reference]
/Data/Packages/PHP/syntax_test_php.php:899:5: Unexpected symbol found ['Y' reference]
/Data/Packages/PHP/syntax_test_php.php:1445:10: Unexpected symbol found ['embedHtml' definition]
/Data/Packages/PHP/syntax_test_php.php:1562:1: Unexpected symbol found ['var_dump' reference]
/Data/Packages/PHP/syntax_test_php.php:661:14: Unexpected symbol found ['Foo' reference]
/Data/Packages/PHP/syntax_test_php.php:67:39: Unexpected symbol found ['fn_b' definition]
/Data/Packages/PHP/syntax_test_php.php:1527:7: Unexpected symbol found ['D' definition]
/Data/Packages/PHP/syntax_test_php.php:756:14: Unexpected symbol found ['scalarReturnType' definition]
/Data/Packages/PHP/syntax_test_php.php:961:17: Unexpected symbol found ['abc' reference]
/Data/Packages/PHP/syntax_test_php.php:1228:1: Unexpected symbol found ['preg_replace' reference]
/Data/Packages/PHP/syntax_test_php.php:591:7: Unexpected symbol found ['ClassName' definition]
/Data/Packages/PHP/syntax_test_php.php:891:7: Unexpected symbol found ['B' definition]
/Data/Packages/PHP/syntax_test_php.php:954:27: Unexpected symbol found ['bar' reference]
/Data/Packages/PHP/syntax_test_php.php:1432:13: Unexpected symbol found ['var_dump' reference]
/Data/Packages/PHP/syntax_test_php.php:158:10: Unexpected symbol found ['a' definition]
/Data/Packages/PHP/syntax_test_php.php:28:31: Unexpected symbol found ['Another' definition]
/Data/Packages/PHP/syntax_test_php.php:1419:97: Unexpected symbol found ['ID: myid' local-definition]
/Data/Packages/PHP/syntax_test_php.php:679:1: Unexpected symbol found ['func_call' reference]
/Data/Packages/PHP/syntax_test_php.php:772:14: Unexpected symbol found ['nullableReturnType' definition]
/Data/Packages/PHP/syntax_test_php.php:591:31: Unexpected symbol found ['\MyNamespace\Foo' reference]
/Data/Packages/PHP/syntax_test_php.php:1008:36: Unexpected symbol found ['getMessage' reference]
/Data/Packages/PHP/syntax_test_php.php:1180:18: Unexpected symbol found ['`version`...' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1362:28: Unexpected symbol found ['CSS: meta.embedded.css source.css ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:1398:7: Unexpected symbol found ['OutputsHtml' definition]
/Data/Packages/PHP/syntax_test_php.php:1362:33: Unexpected symbol found ['embedded.css' global-definition]
/Data/Packages/PHP/syntax_test_php.php:581:11: Unexpected symbol found ['Test1' definition]
/Data/Packages/PHP/syntax_test_php.php:1530:21: Unexpected symbol found ['__construct' definition]
/Data/Packages/PHP/syntax_test_php.php:648:19: Unexpected symbol found ['bar' reference]
/Data/Packages/PHP/syntax_test_php.php:894:9: Unexpected symbol found ['MyNamespace\Xyz' reference]
/Data/Packages/PHP/syntax_test_php.php:901:5: Unexpected symbol found ['Z' reference]
/Data/Packages/PHP/syntax_test_php.php:1039:36: Unexpected symbol found ['getMessage' reference]
/Data/Packages/PHP/syntax_test_php.php:581:25: Unexpected symbol found ['stdClass' reference]
/Data/Packages/PHP/syntax_test_php.php:1002:36: Unexpected symbol found ['getMessage' reference]
/Data/Packages/PHP/syntax_test_php.php:782:14: Unexpected symbol found ['nullableObjectReturnType' definition]
/Data/Packages/PHP/syntax_test_php.php:591:59: Unexpected symbol found ['\MyNamespace\Baz' reference]
/Data/Packages/PHP/syntax_test_php.php:973:21: Unexpected symbol found ['B' reference]
/Data/Packages/PHP/syntax_test_php.php:1015:36: Unexpected symbol found ['getMessage' reference]
/Data/Packages/PHP/syntax_test_php.php:1262:1: Unexpected symbol found ['preg_replace' reference]
/Data/Packages/PHP/syntax_test_php.php:763:14: Unexpected symbol found ['classReturnType' definition]
/Data/Packages/PHP/syntax_test_php.php:97:44: Unexpected symbol found ['C' definition]
/Data/Packages/PHP/syntax_test_php.php:184:10: Unexpected symbol found ['array_values_from_keys' definition]
/Data/Packages/PHP/syntax_test_php.php:1399:14: Unexpected symbol found ['embedHtml' definition]
/Data/Packages/PHP/syntax_test_php.php:1363:7: Unexpected symbol found ['CSS: entity.name.tag ' local-definition]
/Data/Packages/PHP/syntax_test_php.php:168:10: Unexpected symbol found ['d' definition]
/Data/Packages/PHP/syntax_test_php.php:581:45: Unexpected symbol found ['Countable' reference]
/Data/Packages/PHP/syntax_test_php.php:1363:14: Unexpected symbol found ['name.tag' global-definition]
/Data/Packages/PHP/syntax_test_php.php:1362:53: Unexpected symbol found ['css' global-definition]

Before we update the branch, it would be good to get the branch in a green state first.

As one data point, the PHP test doesn't fail for fa6b8629 (the commit used by syntect master), however, it's also somewhat shorter when compared to (48k on fa6b8629 vs 67k on st3).

[varungandhi-src]

This is completed done now with #10. We had to introduce a hack for PHP; tracking that in #8.