Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for automatically taking screenshots at the end of each UI test (passed or failed). #130

Merged
merged 25 commits into from
Nov 1, 2024

Conversation

PiotrKarczmarz
Copy link
Collaborator

Implemented ability to automatically take screenshots for UI tests, locally and when using GitHub Actions. A screenshot is taken at the end of every UI test (all tests inherited from PlaywrightTestsBase class).

Currently VsTestSettings(TakeScreenshotOnFailure = true) attribute doesn't work for async tests (Task async or void async), which is way the custom solution was implemented.

  • Updated Cake Build and Nightly Build to include support for taking screenshots via GitHub Actions.
  • Additional logging for Solution_Name_Is_Added_To_Chat_Input(), which very rarely fails.
  • Additional logging for PlaywrightTestsBase.GetChatContextTags()
  • Fixed logging for TestBase.OpenSolution()

Copy link

github-actions bot commented Oct 31, 2024

Test Results

13 tests  +13   13 ✅ +13   6m 52s ⏱️ + 6m 52s
 1 suites + 1    0 💤 ± 0 
 1 files   + 1    0 ❌ ± 0 

Results for commit 5800023. ± Comparison against base commit 36dcfdf.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOICE

@PiotrKarczmarz PiotrKarczmarz merged commit ed19db1 into main Nov 1, 2024
3 checks passed
@PiotrKarczmarz PiotrKarczmarz deleted the piotr/uitests-ci-improvements branch November 1, 2024 07:15
tomaszgolebiowski pushed a commit that referenced this pull request Dec 11, 2024
…st (passed or failed). (#130)

Implemented ability to automatically take screenshots for UI tests,
locally and when using GitHub Actions. A screenshot is taken at the end
of every UI test (all tests inherited from `PlaywrightTestsBase` class).

Currently `VsTestSettings(TakeScreenshotOnFailure = true)` attribute
doesn't work for async tests (`Task async` or `void async`), which is
way the custom solution was implemented.

- Updated Cake Build and Nightly Build to include support for taking
screenshots via GitHub Actions.
- Additional logging for Solution_Name_Is_Added_To_Chat_Input(), which
very rarely fails.
- Additional logging for PlaywrightTestsBase.GetChatContextTags()
- Fixed logging for TestBase.OpenSolution()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants