-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for automatically taking screenshots at the end of each UI test (passed or failed). #130
Merged
+141
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uploading screenshots as artifacts
…r vscode-v1.40.0 tag)
abeatrix
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOICE
tomaszgolebiowski
pushed a commit
that referenced
this pull request
Dec 11, 2024
…st (passed or failed). (#130) Implemented ability to automatically take screenshots for UI tests, locally and when using GitHub Actions. A screenshot is taken at the end of every UI test (all tests inherited from `PlaywrightTestsBase` class). Currently `VsTestSettings(TakeScreenshotOnFailure = true)` attribute doesn't work for async tests (`Task async` or `void async`), which is way the custom solution was implemented. - Updated Cake Build and Nightly Build to include support for taking screenshots via GitHub Actions. - Additional logging for Solution_Name_Is_Added_To_Chat_Input(), which very rarely fails. - Additional logging for PlaywrightTestsBase.GetChatContextTags() - Fixed logging for TestBase.OpenSolution()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ability to automatically take screenshots for UI tests, locally and when using GitHub Actions. A screenshot is taken at the end of every UI test (all tests inherited from
PlaywrightTestsBase
class).Currently
VsTestSettings(TakeScreenshotOnFailure = true)
attribute doesn't work for async tests (Task async
orvoid async
), which is way the custom solution was implemented.