pool: fix loop variables in tests

[bobheadxi]

This has been a long-standing discussion (golang/go#20733, golang/go#56010) but today, variables in iterations are per-loop, not per-iteration, so you need to copy these values for them to be used inside p.Go.

Add a t.Log inside p.Go in the corresponding tests to see that previously, we're always comparing against the last value in the iteration, i.e. 100, and after the change the correct value is used:

before - always the last value

after - uses the correct value

=== CONT TestContextPool/limit/100 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 === CONT TestContextPool/limit/100 context_pool_test.go:128: 100 context_pool_test.go:128: 100 context_pool_test.go:128: 100 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 === CONT TestContextPool/limit/1 context_pool_test.go:128: 100 === CONT TestContextPool/limit/100 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 context_pool_test.go:128: 100 context_pool_test.go:128: 100 === CONT TestContextPool/limit/1 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 === CONT TestContextPool/limit/1 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 context_pool_test.go:128: 100 context_pool_test.go:128: 100 === CONT TestContextPool/limit/1 context_pool_test.go:128: 100 === CONT TestContextPool/limit/10 context_pool_test.go:128: 100 context_pool_test.go:128: 100

=== CONT TestContextPool/limit/1 context_pool_test.go:130: 1 === CONT TestContextPool/limit/100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 === CONT TestContextPool/limit/10 context_pool_test.go:130: 10 === CONT TestContextPool/limit/100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100 context_pool_test.go:130: 100

[codecov-commenter]

Codecov Report

Merging #14 (77ca0f9) into main (73ebfbf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          10       10           
  Lines         350      350           
=======================================
  Hits          348      348           
  Misses          2        2           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[camdencheek]

Good catch, thanks!