Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

rename command not in initialization response #342

Closed
Dbz opened this issue Nov 26, 2018 · 6 comments · Fixed by #343
Closed

rename command not in initialization response #342

Dbz opened this issue Nov 26, 2018 · 6 comments · Fixed by #343

Comments

@Dbz
Copy link

Dbz commented Nov 26, 2018

My language client doesn't know go-langserver can perform renames because go-langserver doesn't add the capability in the initialize response. Would we be able to add that?

I would be happy to make a PR myself if someone can help point me in the right direction. (I just started learning Go this past week and completed a Udemy course on it, and this would be a fun first PR.)

@slimsag
Copy link
Member

slimsag commented Nov 26, 2018

@Dbz
Copy link
Author

Dbz commented Nov 26, 2018

Oh perfect 🎉 I'll make a PR as soon as I get home from work

@Dbz
Copy link
Author

Dbz commented Nov 27, 2018

Had to steal my PR @fannheyward ! I'm teasing. I'm glad it got in and that I could help with creating the issue :)

@fannheyward
Copy link
Contributor

@Dbz sorry for steal your PR. Just see that you have not submit for hours, so I made it.

@Dbz
Copy link
Author

Dbz commented Nov 27, 2018

I know, I just got home from work. But it is OK - I was just teasing. What is important is that we help each other build better software, and we're doing that. It doesn't matter if I do it, or if you do it. I'm glad there are more people out there who want to improve the project 👍

@slimsag
Copy link
Member

slimsag commented Nov 27, 2018

Haha I didn't notice the author was different, my bad :P FWIW CI just detected a (unrelated) data race if anyone wants to look into that 😜#344

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants