Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid picking up global state for snapshot tests #297

Open
varungandhi-src opened this issue Dec 22, 2023 · 0 comments
Open

Avoid picking up global state for snapshot tests #297

varungandhi-src opened this issue Dec 22, 2023 · 0 comments
Labels
bug Something isn't working graph/scip-typescript team/graph

Comments

@varungandhi-src
Copy link
Contributor

varungandhi-src commented Dec 22, 2023 •
edited
Loading

I had a confusing problem where React 18.2.0 symbols were getting emitted despite no mentions in the repo, causing a mismatch between CI and local snapshots. The problem was that I had a global ~/node_modules folder with an older version of @types/react. b0c554b (#296)

We should exclude global deps during tests.
@varungandhi-src varungandhi-src added the bug Something isn't working label Dec 22, 2023
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working graph/scip-typescript team/graph
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varungandhi-src