Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls with more than 2 arguments are not handled #5

Closed
aryx opened this issue Oct 24, 2022 · 4 comments · Fixed by #7
Closed

Calls with more than 2 arguments are not handled #5

aryx opened this issue Oct 24, 2022 · 4 comments · Fixed by #7

Comments

@aryx
Copy link

aryx commented Oct 24, 2022

The grammar hardcoded Calls with one or two arguments, but does not allow more.
We should use some repeat() in the grammar.
@aryx
Copy link
Author

aryx commented Nov 22, 2022

@tjdevries are you accepting pull requests for this repository, or this project is unmaintained and I should create a fork instead?

@tjdevries
Copy link
Contributor

You can create a PR! Sorry, I was on paternity leave during October, so I completely missed this. I'll gladly review!

@aryx
Copy link
Author

aryx commented Nov 23, 2022

Fantastic! And congrats for the kid (and good luck ...).
I'll try to make a PR in the next few weeks.

@aryx
Copy link
Author

aryx commented Nov 23, 2022

As an example of this issue, the tree-sitter-jsonnet parser can't parse std.jsonnet, the official
standard library: https://github.com/google/jsonnet/blob/master/stdlib/std.jsonnet

aryx pushed a commit to semgrep/tree-sitter-jsonnet that referenced this issue Dec 8, 2022
Support calls with more than 2 arguments
edd4409 
This closes sourcegraph#5

test plan:
make test
@aryx aryx mentioned this issue Dec 8, 2022
Merged
tjdevries pushed a commit that referenced this issue Dec 11, 2022
@tjdevries
Support calls with more than 2 arguments
f4e2d85 
This closes #5

test plan:
make test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support calls with more than 2 arguments semgrep/tree-sitter-jsonnet
2 participants
@aryx @tjdevries